More licensing fun: Automated correction edition #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reak currently working license experessions
|
nice work! |
jezdez
approved these changes
May 11, 2024
There was a problem hiding this comment.
Tiny nit, licenses (plural) is slightly more descriptive ;)
dholth
reviewed
May 13, 2024
pyproject.toml
Outdated
| @@ -3,14 +3,11 @@ requires = ["setuptools>=61.0"] | |||
| build-backend = "setuptools.build_meta" | |||
|
|
|||
| [tool.setuptools] | |||
| package-dir = {"" = "conda_recipe_manager"} | |||
There was a problem hiding this comment.
This line caused it to error looking for conda_recipe_manager.tests as if the top level directory was what you got when "import conda_recipe_manager"
|
|
||
| [tool.setuptools.package-data] | ||
| "conda_recipe_manager" = ["py.typed", "*.json"] | ||
| exclude = ["tests"] |
There was a problem hiding this comment.
This exclude prevents it from packaging "import tests" as a new top-level Python module when this is installed.
py.typed and *.json appear to be included in the wheel without the package-data configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we're just getting started...
This comes out of discussions had in #45, #55, #57 and in Slack.
This PR introduces a new
SpdxUtilslibrary that provides a more advanced mechanism for correcting SPDX licenses than the simple patch-table introduced in #55From local testing, this PR reduces the number of SPDX errors from
rattler-buildin theanaconda_recipes_01test recipe set from ~160 (prior to #55) to 25.This work is far from perfect, but I think it is a "good enough" solution for the time being. We'll learn and improve our approach with this starting point.