Skip to content

Conversation

@h-vetinari
Copy link
Member

Follow-up from #460, which picked up a conflict for an aarch-specific patch.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19023251028. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Member Author

It looks like some abseil mismatch with the vendored xla. Interesting that linux-64 isn't hitting this. 🤔

external/local_xla/xla/backends/cpu/runtime/convolution_thunk_internal.h:345:71: error: no matching function for call to 'tsl::CountDownAsyncValueRef<tsl::Chain>::CountDown() const'
  345 |           auto on_done = [count_down]() mutable { count_down.CountDown(); };
      |                                                   ~~~~~~~~~~~~~~~~~~~~^~
In file included from external/local_xla/xla/backends/cpu/runtime/convolution_thunk_internal.h:26,
                 from external/local_xla/xla/backends/cpu/runtime/convolution_thunk_f16.cc:16:

@dslarm
Copy link
Contributor

dslarm commented Nov 11, 2025

hadn't spotted you'd started on this - my PR #465 has the fix for this compile error - shall we continue there?

@h-vetinari
Copy link
Member Author

hadn't spotted you'd started on this - my PR #465 has the fix for this compile error - shall we continue there?

Fine by me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants