-
-
Notifications
You must be signed in to change notification settings - Fork 89
No hermetic #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
No hermetic #421
Conversation
…nda-forge-pinning 2025.02.16.04.28.19
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13358313095. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.02.16.04.28.19
recipe/build.sh
Outdated
| # https://github.com/tensorflow/tensorflow/pull/86413#issuecomment-2648797177 | ||
| # Disable the use of HERMETIC_CUDA | ||
| echo "build --config=cuda_wheel" >> .bazelrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really the only meaningful change I made. The rest was untabbing.
| exit 1 | ||
| export TF_CUDA_COMPUTE_CAPABILITIES=sm_35,sm_50,sm_60,sm_62,sm_70,sm_72,sm_75,sm_80,sm_86,sm_87,sm_89,sm_90,compute_90 | ||
| export TF_CUDA_PATHS="${PREFIX},${CUDA_HOME}" | ||
| # export HERMETIC_CUDA_COMPUTE_CAPABILITIES=sm_60,sm_70,sm_75,sm_80,sm_86,sm_89,sm_90,compute_90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this will cause configure to hang:
https://github.com/tensorflow/tensorflow/blob/6550e4bd80223cdb8be6c3afd1f81e86a4d433c3/configure.py#L994-L999
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you knowledgeable enough to explain why to upstream? They think we don’t see the hermetic pathway.
Upstream suggests to not use hermetic cuda
tensorflow/tensorflow#86413 (comment)
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)