Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented Dec 5, 2021

Closes: #178

This PR has been triggered in an effort to update grpc_cpp142.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1540809438, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2021

@xhochy could unpin six here?

#151 (comment)

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2021

I don't want to make the changes for fear that you have already started the builds.

@xhochy
Copy link
Member

xhochy commented Dec 5, 2021

Feel free to push, I'll start builds in roughly 2h but will post here before.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2021

From comments in the tensorflow source, it seems that they were trying to help pip solve dependencies for astunparse. However, from the github issues on astunparse, it seems that it isn't necessary:
simonpercivall/astunparse#65

I've also audited the tensorflow code directly, for v2.6.2 and master, and it seems that wheel is never imported directly in the python source

Would it be acceptable to remove the pinning on wheel:
tensorflow/tensorflow#53308 (comment)

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2021

Finally. the conda-forge package for astunparse does not require wheel:
https://github.com/conda-forge/astunparse-feedstock/blob/master/recipe/meta.yaml

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2021

I think the rest of the loosening can happen later tbh. And you might even be able to revert the six loosing. Ultimately, 2.7 addresses many of the challenges and we can likely build that if we work together on it insteadof spending too much time here.

I might personally unpin things like h5py since I think it is compatible with higher versions (tensorflow team just doesn't seem to be testing too hard with newer versions, they seemed to have to update to support python 3.10)

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 5, 2021

I just don't think such hacking is really in our perview without opening issues with upstream and they seem to have already addressed it in a recent version.

@xhochy
Copy link
Member

xhochy commented Dec 5, 2021

I'll try to build this now.

@xhochy
Copy link
Member

xhochy commented Dec 8, 2021

@conda-forge/tensorflow I would appreciate a ✅ here for the manual builds; osx ones are at https://anaconda.org/uwe.korn, linux ones at https://anaconda.org/uwe.korn-tf-gpu

Logs:

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 8, 2021

Realistically, what are we supposed to check? These logs are gigantic.

I'm tempted to say "looks good" but I can guarantee I didn't look at all the lines.

@xhochy
Copy link
Member

xhochy commented Dec 8, 2021

isuruf did check whether I used the build-locally script and esp. on OSX that the right SDK was used; mainly as far as I understood the CFEP: I need a second approval for uploading them.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 8, 2021

i approve your upload of these packages.

@xhochy
Copy link
Member

xhochy commented Dec 8, 2021

Thanks, uploaded!

@xhochy xhochy merged commit 9a4cd82 into conda-forge:master Dec 8, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-grpc_cpp142-0-1_h83893e branch December 8, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bye

5 participants