-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Added initial set of packages belonging to the new eozilla ecosystem. #31256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/procodile/procodile/recipe.yaml:
For recipes/procodile/procodile/recipe.yaml:
For recipes/eozilla/recipe.yaml:
For recipes/eozilla/recipe.yaml:
For recipes/cuiman/cuiman/recipe.yaml:
For recipes/cuiman/cuiman/recipe.yaml:
For recipes/appligator/appligator/recipe.yaml:
For recipes/appligator/appligator/recipe.yaml:
For recipes/gavicore/gavicore/recipe.yaml:
For recipes/gavicore/gavicore/recipe.yaml:
For recipes/wraptile/wraptile/recipe.yaml:
For recipes/wraptile/wraptile/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18690367460. Examine the logs at this URL for more detail. |
|
I am willing to be a maintainer. |
|
I am willing to be a maintainer. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/wraptile/recipe.yaml:
For recipes/appligator/recipe.yaml:
For recipes/procodile/recipe.yaml:
For recipes/cuiman/recipe.yaml:
For recipes/gavicore/recipe.yaml:
For recipes/eozilla/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19104466294. Examine the logs at this URL for more detail. |
|
Hi @conda-forge/help-python, The recipes have passed all checks and linting. Is there anything else I need to do to proceed? |
|
I am willing to be a maintainer. |
Yes. Please address #31256 (comment). |
recipes/appligator/recipe.yaml
Outdated
| @@ -0,0 +1,42 @@ | |||
| context: | |||
| version: 0.0.1 | |||
| python_min: 3.10 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only set python_min if the minimum required version is higher than the conda-forge default.
| python_min: 3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf Done. Thanks for the fast feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove that line and all others that are <=3.10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
Are all these packages just a namespace grab? @conda-forge/core They are on PyPI, but I'm not sure how to feel about this. We used to review packages :-/ |
No, they are true packages, but well, yes, currently empty. Please take a look at eo-tools/eozilla where the new packages in this PR live and will be release from in the future. I want to ensure that the names of the package we selected would still be available. It took us a some effort to (1) the find the names that our team would agree on, and (2) that the names are still free on PyPI and conda. We want to avoid extra effort in renaming stuff after a name has been taken by someone else before we have a first dev release. |
Yeah I would be merging a namespace grab, not a package, also I cannot review a code that is not here. The summary doesn't even say what they will do. I do not feel comfortable doing this b/c I cannot say what they will do once published. Sure, an existing package can change as it evolves, but in this case there isn't one and whatever I approve here is not what it will be once released. @conda-forge/core, if anyone wants to take over this review, please do. |
|
Note that I'm not blocking the merge. I just don't want to be the one doing it. |
I'll provide the first releases with complete metadata asap. |
|
Hey, just a quick note that we're discussing this case in the larger context of how to deal with such situations in conda-forge/cfep#64. Overall, I think we'll tend to allow it when there's good reason (I can understand that it's hard to find a name that's free both on PyPI and on conda-forge, and we want to enable people to pull that off); you'll just need a little bit more patience please. Once the CFEP is through, we should be able to get this done. |
Hi @h-vetinari, thanks so much for taking care! However, I'm planning to close this PR and instead place 6 individual ones with recipes generated by grayskull from the related functional and already published PyPI packages with same names. This is because I realized (a little late) that I cannot get the 6 packages deployed at once because they depend on each other in a certain order. |
Recipes within a PR here are allowed to depend on each other (except circularly, of course), and will be built in the correct order. So you don't need to break up the PR, unless that helps your workflow (or the reviewers). |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/eozilla/meta.yaml:
For recipes/gavicore/meta.yaml:
For recipes/cuiman/meta.yaml:
For recipes/cuiman/meta.yaml:
For recipes/procodile/meta.yaml:
For recipes/wraptile/meta.yaml:
For recipes/appligator/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19105809339. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/gavicore/meta.yaml:
For recipes/procodile/meta.yaml:
For recipes/appligator/meta.yaml:
For recipes/wraptile/meta.yaml:
For recipes/eozilla/meta.yaml:
For recipes/cuiman/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19106146546. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi @conda-forge/help-python, The recipes have passed all checks and linting. Is there anything else I need to do to proceed? FYI @ocefpaf & @h-vetinari: all packages are now fully functional & tested, just as their counterparts on PyPI. |
h-vetinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thanks for your patience on this! :)
PS. I love the suite of reptile-tech-puns! I had to squint at cuiman to get caiman though, and I had never heard of a gavial before 😅
Checklist
If static libraries are linked in, the license of the static library is packaged.Package does not ship static libraries. If static libraries are needed, follow CFEP-18.url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).When in trouble, please check our knowledge base documentation before pinging a team.