-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add tensorflow-text package #29008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tensorflow-text package #29008
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tensorflow-text/meta.yaml:
For recipes/tensorflow-text/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13100468903. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tensorflow-text/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13100528322. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tensorflow-text/meta.yaml:
For recipes/tensorflow-text/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13100628010. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tensorflow-text/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13100856685. Examine the logs at this URL for more detail. |
|
@conda-forge/tensorflow @Anselmoo Could use some substantial help... on where to go from here (especially regarding Bazel https://github.com/tensorflow/text). This is a package with millions of monthly downloads on PyPi (https://pypistats.org/packages/tensorflow-text) yet not in Conda. |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tensorflow-text/meta.yaml:
For recipes/tensorflow-text/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13100934111. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tensorflow-text/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13101023927. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13101116245. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tensorflow-text/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13622010968. Examine the logs at this URL for more detail. |
Co-authored-by: Mark Harfouche <[email protected]>
Co-authored-by: Mark Harfouche <[email protected]>
|
Someone who could decrypt the Bazel scripts in the https://github.com/tensorflow/text repository would be instrumental. |
lol this just subscribes me again. |
h-vetinari
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I can be much help here, beyond pointing out that you can try to copy the build setup from the tensorflow feedstock. The person most intimately familiar (Uwe; "xhochy") with the whole custom toolchain setup is unfortunately not available for the next ~month or so.
bazel is just enormously hostile to the kind of things we need to do in packaging (use a toolchain from a non-default location, use system libraries, cross-compilation, etc.). I just experienced this again yesterday in conda-forge/tensorflow-feedstock#415, but the trail of bodies is long (e.g. #16888, bazelbuild/bazel#20947). I spend way too much time on conda-forge as it is, but my mind recoils at engaging with a build system that is designed to make my tasks impossible.
On track, except that Hermetic Python needs to get rid of. |
|
@hmaarrfk Was the decision from the TensorFlow feedstock to get rid of Hermetic Python, or embrace it? |
|
I’m honestly not sure what hermetic python is. I’m just trying to survive. My guess is that conda forge already has the tooling needed to deal with what hermetic python was doing so it might be safe to delete it. |
|
@h-vetinari @hmaarrfk |
a little followup on this. We found that we needed to use hermetic cuda, and that we had to patch out a few things in tensorflow to get it to work. Tensorflow gives me nightmares btw, everyday i wish i never have to use it again.... |
|
Running this locally, the first thing i see is that it is trying to download the tensorflow archive.... this seems suspect... this seems really suspect.... |
|
Unfortunately, most of this script is simply not applicable to conda-forge https://github.com/tensorflow/text/blob/master/oss_scripts/run_build.sh I'm sorry to say, but you will have to go through in detail and see what is applicable instead of trying to decipher tensorflow's way. It may need a combination of the two. Hopefully this is enough guidance. |
Yeah, I currently have legacy code running in Keras-NLP and seriously considering to eventually migrate to PyTorch Lightning... Anyways, great thanks for the information. @hmaarrfk |
If you aren’t deploying your code to others, pip might work…. |
|
@hmaarrfk I guess it's necessary to have CUDA builds if this package depends on TensorFlow during build-time? |
|
Very likely. |
|
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
|
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).Closes #19578