-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for ada-url #28258
base: main
Are you sure you want to change the base?
Add recipe for ada-url #28258
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
8d63ed2
to
61fa479
Compare
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12520530764. Examine the logs at this URL for more detail. |
9b5c94e
to
897f389
Compare
Hey! This package is ready for review @conda-forge/help-c-cpp, but I'm not sure why the linter is failing? I've followed the instructions given in: https://prefix.dev/blog/building_cpu_optimized_packages but I'm getting a linter error now. |
Ok, so I looked more into it and it seems that while the conda-smithy I'm guessing this has no easy fix? |
So I managed to get the syntax past the lint checker, thought obviously it's not ideal. |
Hi @rHermes looks good to me! I think there is a slight bug in the linter code that I can take a look at on Monday and then we can hopefully merge. |
Have you checked if passing |
My interest in this is mostly to build this like a static library, so I have not played around with those options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've followed all outlined requirements, the only one I'm insecure about is the "static" requirement. ada normally doesn't ship a dynamic library, it's only exporting headers and lib/libada.a. I don't know if this disqualifies it or not, but I needed this for my own purposes, and so I thought I would upstream this :)
Our channel policy is that packages are shared by default and static optionally. e.g. You can ship the ship the static library in a separate output called "ada-url-static". From a cursory glance, it doesn't seem like there is a strong argument against having shared by default since there seems to be many bindings packages (for python, zig, lua, ...) which could reuse a shared library.
Hey, this is my first submission, so please bear with me 😅
I think I've followed all outlined requirements, the only one I'm insecure about is the "static" requirement. ada normally doesn't ship a dynamic library, it's only exporting headers and
lib/libada.a
. I don't know if this disqualifies it or not, but I needed this for my own purposes, and so I thought I would upstream this :)I have not tested the windows build, but I hope the CI will.
Please let me know if you have any comments!
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).