Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gcc-arm-none-eabi #28117

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

nmosim
Copy link

@nmosim nmosim commented Nov 6, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 6, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gcc-arm-none-eabi/meta.yaml) and found some lint.

Here's what I've got...

For recipes/gcc-arm-none-eabi/meta.yaml:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

@nmosim nmosim force-pushed the add-gcc-arm-none-eabi branch from ced22f1 to c7a30e8 Compare November 6, 2024 15:17
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gcc-arm-none-eabi/meta.yaml) and found it was in an excellent condition.

@nmosim nmosim force-pushed the add-gcc-arm-none-eabi branch from c7a30e8 to 6534828 Compare November 7, 2024 09:27
@nmosim nmosim force-pushed the add-gcc-arm-none-eabi branch from 6534828 to 203059f Compare November 8, 2024 15:38
@nmosim nmosim force-pushed the add-gcc-arm-none-eabi branch from 2ce8aca to 420a44e Compare November 8, 2024 15:52
@nmosim nmosim force-pushed the add-gcc-arm-none-eabi branch from 420a44e to 7ba0977 Compare November 8, 2024 16:08
@nmosim nmosim changed the title Add gcc-arm-none-eabi v13.3.rel1 Add gcc-arm-none-eabi Nov 8, 2024
@nmosim
Copy link
Author

nmosim commented Nov 12, 2024

@conda-forge/help-c-cpp Ready for review!

@nmosim
Copy link
Author

nmosim commented Nov 12, 2024

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be added but you should rather use the toolchains we already provide in conda-forge.

@nmosim
Copy link
Author

nmosim commented Dec 3, 2024

I don't think this should be added but you should rather use the toolchains we already provide in conda-forge.

Which toolchain did you mean exactly? This toolchain is used for embedded processors (e.g. ARM Cortex) and it is not available on conda-forge yet.

@carterbox
Copy link
Member

I think what @xhochy means is that we already have compiler packages which can target the aarch64 architecture. Compiler packages are special because they require a specific package structure and other changes in order for the rest of our infrastructure to be able to use the compiler. It might be best if you appear at one of our meetings or start a discussion on our Zulip.

https://conda-forge.org/community/getting-in-touch/

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants