-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add greedy #28069
base: main
Are you sure you want to change the base?
Add greedy #28069
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/greedy/meta.yaml:
|
…sort to a single recipe maintainer
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/greedy/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp ready for review please! |
recipes/greedy/build.sh
Outdated
# A dummy greedy repo is cloned because CMakeLists.txt requires | ||
# .git dir | ||
|
||
# Clone the repository into a temporary directory | ||
git clone https://github.com/pyushkevich/greedy /tmp/greedy | ||
|
||
# Change to the directory where the source is located | ||
cd /tmp/greedy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should patch the sources rather than doing this.
Also the current implementation of this completely ignores the version number and just takes the latest version of the sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for this oversight. I've removed these lines of codes as they were mainly experimental.
@conda-forge/help-c-cpp sorry for pinging again. |
@conda-forge/help-c-cpp please accept my sincere apologies for pinging again. I was just wondering if this PR can be closed soon. Thank you! |
test: | ||
commands: | ||
- greedy -version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you are shipping a C-API in addition to a CLI. If you are shipping a C-API, you need to do the following:
- Add existence tests for each of the classes of artifacts you are shipping: libraries, config files, headers
- Add run_exports to your package which will pin the appropriate ABI for downstream packages (please read the conda-build documentation if you are unfamiliar with run_exports).
- Remove static libraries or switch to shared libraries. Our channel policy prohibits shipping static libraries by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pyushkevich @jilei-hao @dzenanz Hello! I've been trying to add greedy registration tool on conda-forge and I'd appreciate your help on addressing these remarks. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have used Greedy, so I will leave this to @pyushkevich and @jilei-hao.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).