Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add greedy #28069

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add greedy #28069

wants to merge 20 commits into from

Conversation

Dhananjhay
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/greedy/meta.yaml:
    • lints:
      • Feedstock with the same name exists in conda-forge.
      • The following maintainers have not yet confirmed that they are willing to be listed here: pyushkevich. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 31, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/greedy/meta.yaml) and found some lint.

Here's what I've got...

For recipes/greedy/meta.yaml:

  • There are too few lines. There should be one empty line at the end of the file.
  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/greedy/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 31, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/greedy/meta.yaml) and found some lint.

Here's what I've got...

For recipes/greedy/meta.yaml:

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/greedy/meta.yaml) and found it was in an excellent condition.

@Dhananjhay
Copy link
Contributor Author

@conda-forge/help-c-cpp ready for review please!

Comment on lines 3 to 10
# A dummy greedy repo is cloned because CMakeLists.txt requires
# .git dir

# Clone the repository into a temporary directory
git clone https://github.com/pyushkevich/greedy /tmp/greedy

# Change to the directory where the source is located
cd /tmp/greedy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should patch the sources rather than doing this.

Also the current implementation of this completely ignores the version number and just takes the latest version of the sources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for this oversight. I've removed these lines of codes as they were mainly experimental.

@Dhananjhay Dhananjhay requested a review from chrisburr December 6, 2024 13:56
@Dhananjhay
Copy link
Contributor Author

@conda-forge/help-c-cpp sorry for pinging again.

recipes/greedy/build.sh Outdated Show resolved Hide resolved
@Dhananjhay
Copy link
Contributor Author

Dhananjhay commented Dec 20, 2024

@conda-forge/help-c-cpp please accept my sincere apologies for pinging again. I was just wondering if this PR can be closed soon. Thank you!

Comment on lines +28 to +30
test:
commands:
- greedy -version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you are shipping a C-API in addition to a CLI. If you are shipping a C-API, you need to do the following:

  • Add existence tests for each of the classes of artifacts you are shipping: libraries, config files, headers
  • Add run_exports to your package which will pin the appropriate ABI for downstream packages (please read the conda-build documentation if you are unfamiliar with run_exports).
  • Remove static libraries or switch to shared libraries. Our channel policy prohibits shipping static libraries by default.

Copy link
Contributor Author

@Dhananjhay Dhananjhay Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pyushkevich @jilei-hao @dzenanz Hello! I've been trying to add greedy registration tool on conda-forge and I'd appreciate your help on addressing these remarks. Thank you!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have used Greedy, so I will leave this to @pyushkevich and @jilei-hao.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants