-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jupyter-(docprovider|collaboration-ui) 1.0.0 #28051
add jupyter-(docprovider|collaboration-ui) 1.0.0 #28051
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python @conda-forge/jupyter-collaboration ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
@@ -0,0 +1,57 @@ | |||
{% set version = "1.0.0" %} | |||
{% if 1 %}{% set jupyterlab = "jupyterlab >=4.2.0,<5" %}{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this? It will became a complication as we move to the new recipe format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I need the version so people don't get broken stuff? Yes. Does it need the if
? No, but I'm tired of fixing bot dupes, and this seems to confuse it enough that it doesn't touch things it shouldn't.
If the new format is preferred, I can just use that instead... last time I excitedly tried, i was told it wasn't ready to be used (even though the example was in here)....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are in slowly transition. I would not merge this if it was another maintainer but I'm sure you will be active and update this when the new format rolls out... Still I recommend removing as much jinja as possible from your existing and future recipes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing as much jinja as possible
Oh, that's my goal when living that conda-forge life. I'd use native YAML anchors, but multi-outputs hate that. But having made enough "forgot to update a python version" errors, DRY wins. I think the new format will improve the situation (even though I think it could have used more existing techniques like JSON-e, patch, etc. and don't like that it doesn't declare a $schema
for completion) but it's a big net step forward, and the significant speed improvements are certainly welcome!
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).References: