-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis Cleanup #2262
Merged
Merged
Travis Cleanup #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To explain a bit more about what is going on with Travis CI builds, add some nice messages in the logs to clarify what these steps are doing. [skip lint] [skip appveyor]
To standardize removal a bit more and make things a bit quieter, get Homebrew's uninstall script and run it on Travis CI. [skip lint] [skip appveyor]
Install Miniconda in the first step and then update and configure the `root` environment in the second step. This will make way for other optimizations later on even though this is not an optimization itself. [skip lint] [skip appveyor]
Instead of making use of Obvious-CI's bootstrap script to install Miniconda, simply download this script ourselves. This is good for a number of reasons including Obvious-CI is being phased out throughout conda-forge, Travis CI is the only CI still making use of the bootstrap script to install Miniconda, bugs can be more easily fixed in conda-forge than Obvious-CI as there are more hands on deck, and additional optimizations to the setup can be made like caching the install script. For all of these reasons and more, we switch over to directly downloading and installing Miniconda on Travis CI. [skip lint] [skip appveyor]
Ran into what appears to be a bug with `conda-build-all` and Python 3 during feedstock conversion. It appears the problem goes away with Python 2. An issue has been filed upstream about the problem. In the interim as this does workaround the issue, would like to switch to Python 2 to clear the current batch of recipes. May be worthwhile keeping this switch until the cause of the bug is better understood and potentially fixed or worked around in a better way. Based off of commit ( cd63d0e ). [ci skip]
jakirkham
force-pushed
the
travis_cleanup
branch
from
January 22, 2017 00:27
fcd9116
to
cf6a74e
Compare
[skip lint] [skip appveyor]
jakirkham
force-pushed
the
travis_cleanup
branch
from
January 22, 2017 00:27
cf6a74e
to
617025f
Compare
jakirkham
commented
Jan 22, 2017
rm -rf $(brew --cache) | ||
echo "" | ||
echo "Removing homebrew from Travis CI to avoid conflicts." | ||
curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/uninstall > ~/uninstall_homebrew.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the .sh
. Fixed in PR ( #2263 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the Travis CI build. Highlights of the changes are listed below. More details can be found in the individual commits and their messages.
Note: Adjusted to include the workaround in PR ( #2261 ), but made it so this is easily revertible. See issue ( conda-tools/conda-build-all#77 ) for info on the underlying problem.
Complimentary to PR ( conda-forge/conda-smithy#443 ).