Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: package torchaudio #17082

Closed
wants to merge 65 commits into from
Closed

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Nov 26, 2021

Necessary for #14474, #17129

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/torchaudio) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Mar 14, 2022
9 tasks
@stale
Copy link

stale bot commented May 19, 2022

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label May 19, 2022
@h-vetinari
Copy link
Member Author

Not stale

@stale stale bot removed the stale will be closed in 30 days label May 19, 2022
@thewchan
Copy link
Contributor

@h-vetinari hey another package I'm maintaining is requiring torchaudio now for dependency... You seem to know a lot more about what's going on with this package, do you feel optimistic about this PR?

@h-vetinari
Copy link
Member Author

@h-vetinari hey another package I'm maintaining is requiring torchaudio now for dependency... You seem to know a lot more about what's going on with this package, do you feel optimistic about this PR?

Hey @thewchan, very sorry for the delay, I had to look for a flat and then move, could not respond to everything in time. I want to revive this PR, especially not that the unix-y parts of kaldi should be solved, we should be able to progress. :)

@thewchan
Copy link
Contributor

@h-vetinari thanks very exciting to hear!

@h-vetinari
Copy link
Member Author

I'm probably just not seeing the forest for the trees, but I'm baffled why zlib isn't being found here.

@mthrok
Copy link

mthrok commented Aug 21, 2023

FYI: We cleaned up the third party dependencies on torchaudio nightly.

  • No longer statically bind libsox. So sox from conda-forge works as-is.
  • libsox integration is built by compiling stub library. This means torchaudio with libsox built can be built without libsox installed in the environment.
  • FFmpeg integration is built using pre-compiled FFmpeg binaries as scaffolding.
  • C++ bindings to flashlight-text and Kaldi were removed. The build process has been simplified a lot.

@h-vetinari
Copy link
Member Author

Hey @mthrok, thanks a lot, that's amazing news! 🤩

I'll try again as soon as there's a new release!

@mmcauliffe
Copy link
Contributor

@h-vetinari looks like the dependency changes are released in 2.1: https://github.com/pytorch/audio/releases/tag/v2.1.0

@hadim hadim mentioned this pull request Sep 28, 2024
10 tasks
@hadim
Copy link
Member

hadim commented Sep 30, 2024

FYI: I opened a new PR at #27715

@h-vetinari
Copy link
Member Author

Superseded by #27715

@h-vetinari h-vetinari closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants