Skip to content
This repository has been archived by the owner on Jun 4, 2022. It is now read-only.

6.1.4 #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

6.1.4 #18

wants to merge 2 commits into from

Conversation

vigsterkr
Copy link

@vigsterkr vigsterkr commented Mar 3, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

Fixes #13
Fixes #15
Fixes #17

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@vigsterkr
Copy link
Author

i guess still too early... will try later

@vigsterkr vigsterkr force-pushed the 6.1.4 branch 4 times, most recently from 1175c52 to f6d3315 Compare March 4, 2020 06:51
@vigsterkr
Copy link
Author

@isuruf is there any chance that i could ask for your help here...? the linux build is failing because of this error:

make[3]: *** No rule to make target '/home/conda/feedstock_root/build_artifacts/shogun-cpp_1583273173027/_build_env/x86_64-conda_cos6-linux-gnu/sysroot/usr/lib/librt.so', needed by 'src/interfaces/python/_shogun.so'.  Stop.

i thought librt should be part of the libc (package). i dont seemed to be able to figure out what's missing from the meta.yaml to have that shared lib available

@isuruf
Copy link
Member

isuruf commented Mar 4, 2020

CMake saves the path of librt from the shogun-cpp feedstock. There was a fix for this in conda-build 3.18.12. Can you try rebuilding shogun-cpp? (Bump the build number)

@vigsterkr
Copy link
Author

@isuruf ah i see... is it ok if i directly push the change into the master of shogun-cpp ? or it should go via a pr?

@isuruf
Copy link
Member

isuruf commented Mar 4, 2020

I guess in this specific case, it's fine.

@vigsterkr vigsterkr force-pushed the 6.1.4 branch 2 times, most recently from f5c491f to b84e98b Compare March 4, 2020 09:56
@vigsterkr
Copy link
Author

@isuruf ok so the latest build that failed definitely picked up the new shogun-cpp build

    shogun-cpp:      6.1.4-h392ae5d_1

but unfortunately still failed with the same No rule to make target .... librt.so

@isuruf
Copy link
Member

isuruf commented Mar 4, 2020

@mingwandroid, any ideas why the cmake build prefix replacements didn't work?

@mingwandroid
Copy link

I'll try to take a look. Probably due to not using a cmake toolchain file though?

@vigsterkr
Copy link
Author

is there anything i can do to get this rolling? should i maybe rebuild shogun-cpp @isuruf (in case things has been fixed by any chance in the meanwhile in upstream)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [36, 36, 44, 44].
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@vigsterkr
Copy link
Author

anybody knows why in case of the last build still h392ae5d_1 is being picked up by the build for shogun-cpp package instead of some newer h5397d2f_3?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

vigsterkr added 2 commits May 12, 2020 08:19
patch mostly based on the patch by dougalsutherland
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [36, 36, 44, 44].
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@vigsterkr
Copy link
Author

mmmm even the last build is still picking up 6.1.4-h392ae5d_1 :o

@isuruf
Copy link
Member

isuruf commented Jul 18, 2020

@conda-forge-admin, rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the 6.1.4
branch of shogun-toolbox/shogun-feedstock. Did you check the "Allow edits from maintainers" box?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants