Skip to content

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update fmt121_spdlog117.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/20744303473 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 6, 2026

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The magma output has been superseded by libmagma-devel.
  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20845314235. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Member

It would have been more important IMO to build #473, because nothing in conda-forge depends on v2.10 yet

@mgorny
Copy link
Contributor

mgorny commented Jan 7, 2026

Ok, I'll add the header fix to that one, and try building it.

@mgorny mgorny force-pushed the rebuild-fmt121_spdlog117-0-1_h983fc7 branch from bf422bb to 58c6c81 Compare January 9, 2026 08:03
@mgorny
Copy link
Contributor

mgorny commented Jan 9, 2026

Since #473 is mostly done (modulo osx), let's start this one to keep the bots busy. This time header removal + win test skip hygiene (#352).

@h-vetinari
Copy link
Member

Since #473 is mostly done (modulo osx), let's start this one to keep the bots busy.

Actually, since it's mostly done (and was only stuck on osx due to scaleway restarting the machine, which Amit kindly fixed), we should merge that PR and get those builds out the door. Before 2.10 GA, anything for 2.10 has the lowest priority, behind every other feedstock that needs the server (and the server is mighty busy anyway because there's a long queue of stuff for vllm and xformers).

So I'm stopping the builds here and merging #473. Unless there's a mega-compelling reason otherwise, let's keep adding relevant changes to this PR (though with running no or minimal CI on cirun) until 2.10 goes GA, then we merge the whole thing.

@mgorny
Copy link
Contributor

mgorny commented Jan 9, 2026

WFM. Do we want to rebuild 2.8.x?

@h-vetinari
Copy link
Member

WFM. Do we want to rebuild 2.8.x?

Once the build queue is completely empty, we could do that. But the pytorch 2.8 & 2.9 migrations are essentially head-to-head with how far they've migrated, so I think it'd also be fine to leave fmt 12.1 for pytorch 2.9+

@h-vetinari
Copy link
Member

Before 2.10 GA, anything for 2.10 has the lowest priority

Actually, I'm tempted to close this PR as soon as the last builds from #473 are through; that's because this is currently holding up the fmt migrator. Do you mind opening a new PR with the state of this? Otherwise I can do it :)

@mgorny
Copy link
Contributor

mgorny commented Jan 10, 2026

Sure, I'll also add other pending commits.

@mgorny mgorny closed this Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants