-
-
Notifications
You must be signed in to change notification settings - Fork 51
Rebuild for fmt 12.1 and spdlog 1.17 #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for fmt 12.1 and spdlog 1.17 #472
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20845314235. Examine the logs at this URL for more detail. |
|
It would have been more important IMO to build #473, because nothing in conda-forge depends on v2.10 yet |
|
Ok, I'll add the header fix to that one, and try building it. |
Issue conda-forge#447 again. Signed-off-by: Michał Górny <mgorny@quansight.com>
Part-of: conda-forge#352 Closes: conda-forge#352
bf422bb to
58c6c81
Compare
Actually, since it's mostly done (and was only stuck on osx due to scaleway restarting the machine, which Amit kindly fixed), we should merge that PR and get those builds out the door. Before 2.10 GA, anything for 2.10 has the lowest priority, behind every other feedstock that needs the server (and the server is mighty busy anyway because there's a long queue of stuff for vllm and xformers). So I'm stopping the builds here and merging #473. Unless there's a mega-compelling reason otherwise, let's keep adding relevant changes to this PR (though with running no or minimal CI on cirun) until 2.10 goes GA, then we merge the whole thing. |
|
WFM. Do we want to rebuild 2.8.x? |
Once the build queue is completely empty, we could do that. But the pytorch 2.8 & 2.9 migrations are essentially head-to-head with how far they've migrated, so I think it'd also be fine to leave fmt 12.1 for pytorch 2.9+ |
Actually, I'm tempted to close this PR as soon as the last builds from #473 are through; that's because this is currently holding up the fmt migrator. Do you mind opening a new PR with the state of this? Otherwise I can do it :) |
|
Sure, I'll also add other pending commits. |
This PR has been triggered in an effort to update fmt121_spdlog117.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/20744303473 - please use this URL for debugging.