NEW: Export CF_TORCH_CUDA_ARCH_LIST to environment #464

carterbox · 2025-12-09T23:32:53Z

Adds activation/deactivation scripts which export CF_TORCH_CUDA_ARCH_LIST into the environment. This variable records the CUDA architectures that were targeted when pytorch was built so that downstream feedstocks can automatically follow the same archs that are used here by adding something like:

export TORCH_CUDA_ARCH_LIST="${CF_TORCH_CUDA_ARCH_LIST}"

to their build scripts.

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Closes #423

…5.12.09.17.39.06

conda-forge-admin · 2025-12-09T23:34:24Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ The magma output has been superseded by libmagma-devel.
ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21009919321. Examine the logs at this URL for more detail.}

recipe/activate.bat

recipe/bld.bat

h-vetinari · 2025-12-14T09:03:44Z

recipe/deactivate.bat

@@ -0,0 +1,6 @@
+@echo on


h-vetinari · 2025-12-14T09:06:54Z

recipe/activate.sh

+if [[ ! -v CF_TORCH_CUDA_ARCH_LIST ]]
+then
+    export CF_TORCH_CUDA_ARCH_LIST="@cf_torch_cuda_arch_list@"
+    export CF_TORCH_CUDA_ARCH_LIST_BACKUP="UNSET"


UNSET is not the greatest name already, but using it on unix is even worse, because there unset is actually a valid command, and we can detect the difference between an unset and an empty environment variable. No such luck on windows, so it makes sense there.

I can imagine keeping the current setup for uniformity if you want to declare this all internal to the package, but then both activate.sh and activate.bat need an explanatory comment.

I can imagine keeping the current setup for uniformity if you want to declare this all internal to the package, but then both activate.sh and activate.bat need an explanatory comment.

This still applies. Windows should have a comment that we cannot distinguish unset from empty, so we use a placeholder. And using a placeholder on unix rather than (more properly) determing whether a variable is set/unset in bash needs a comment that this is for uniformity with windows.

recipe/activate.bat

recipe/activate.sh

recipe/activate.bat

h-vetinari

This is fine from my side. We can incorporate this in the next PR

mgorny · 2026-01-08T12:17:49Z

@h-vetinari, do we want to include it in the old branches as well, or just 2.10 when it is ready?

h-vetinari · 2026-01-08T13:32:36Z

I'd prefer to do this at a version boundary, i.e. only for 2.10

Closes: conda-forge#464 Signed-off-by: Michał Górny <[email protected]>

mgorny · 2026-01-14T17:46:32Z

Looks like the activation script doesn't work on osx:

/Users/runnerx/miniforge3/conda-bld/libtorch_1768358369258/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/etc/conda/activate.d/libtorch_activate.sh: line 3: conditional binary operator expected

https://github.com/conda-forge/pytorch-cpu-feedstock/actions/runs/20980286298/job/60303616215?pr=475
https://github.com/conda-forge/pytorch-cpu-feedstock/actions/runs/20980286298/job/60303616203?pr=475

That said, I wonder if we should be installing them at all for non-CUDA builds. Perhaps we should just make that conditional to cuda_compiler_version != None?

I can do the necessary changes, just need confirmation that I'm not missing something.

mgorny · 2026-01-14T17:47:46Z

(FWICS the problem is that macOS hosts are using bash 3.2, which doesn't support -v operator)

carterbox · 2026-01-14T19:32:47Z

@mgorny, can you please propose a fix? I don't have any macOS devices. Unless you think I can debug this by installing bash 3.2 on a Linux host.

mgorny · 2026-01-14T20:22:14Z

@mgorny, can you please propose a fix? I don't have any macOS devices. Unless you think I can debug this by installing bash 3.2 on a Linux host.

Yeah, I'm pretty sure you can reproduce it with bash 3.2 on Linux. However, as I said above, I think we shouldn't be installing these activation files when PyTorch is built without CUDA, right?

carterbox · 2026-01-14T20:50:00Z

I think we shouldn't be installing these activation files when PyTorch is built without CUDA, right?

OK. I'll wrap the activation install commands in a conditional.

…6.01.13.21.47.52 Other tools: - conda-build 25.11.1 - rattler-build 0.55.0 - rattler-build-conda-compat 1.4.7

mgorny · 2026-01-15T07:03:12Z

Thanks. Testing in #475.

carterbox added 3 commits December 9, 2025 17:22

NEW: Export CF_TORCH_CUDA_ARCH_LIST to environment

33b2933

MNT: Re-rendered with conda-smithy 3.53.3 and conda-forge-pinning 202…

8ebd49f

…5.12.09.17.39.06

BLD: Bump the build

721ceff

carterbox requested review from Tobias-Fischer, baszalmstra, beckermr, benjaminrwilson, h-vetinari, hmaarrfk, jeongseok-meta, mgorny and sodre as code owners December 9, 2025 23:32

h-vetinari reviewed Dec 14, 2025

View reviewed changes

h-vetinari and others added 4 commits December 14, 2025 20:08

trigger CI

49fb407

REF: Use NOT_SET instead of unset to track CF_TORCH_CUDA_ARCH_LIST

4d6a51b

REF: Turn off echo in activation scripts

cbb6c2a

REF: Remove ~ from activation script names

96fa997

carterbox requested a review from h-vetinari December 15, 2025 22:42

mgorny reviewed Dec 16, 2025

View reviewed changes

recipe/activate.bat Show resolved Hide resolved

carterbox commented Dec 16, 2025

View reviewed changes

recipe/activate.sh Show resolved Hide resolved

carterbox commented Dec 16, 2025

View reviewed changes

recipe/activate.bat Show resolved Hide resolved

DOC: Add explanatory comment to activation script

e4b5b38

h-vetinari approved these changes Dec 28, 2025

View reviewed changes

mgorny pushed a commit to mgorny/pytorch-cpu-feedstock that referenced this pull request Jan 10, 2026

[ci skip] NEW: Export CF_TORCH_CUDA_ARCH_LIST to environment

d1514ec

Closes: conda-forge#464 Signed-off-by: Michał Górny <[email protected]>

carterbox added 3 commits January 14, 2026 14:58

BLD: Only install activation scripts for CUDA variant

6f5c94b

Merge remote-tracking branch 'upstream/main' into default-arch-list

99c202e

MNT: Re-rendered with conda-smithy 3.54.1 and conda-forge-pinning 202…

47fe3e7

…6.01.13.21.47.52 Other tools: - conda-build 25.11.1 - rattler-build 0.55.0 - rattler-build-conda-compat 1.4.7

Uh oh!

NEW: Export CF_TORCH_CUDA_ARCH_LIST to environment #464

Are you sure you want to change the base?

NEW: Export CF_TORCH_CUDA_ARCH_LIST to environment #464

Uh oh!

Conversation

carterbox commented Dec 9, 2025

Uh oh!

conda-forge-admin commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

h-vetinari Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

carterbox Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

h-vetinari Dec 14, 2025

Choose a reason for hiding this comment

Uh oh!

carterbox Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

h-vetinari Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

carterbox Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

h-vetinari left a comment

Choose a reason for hiding this comment

Uh oh!

mgorny commented Jan 8, 2026

Uh oh!

h-vetinari commented Jan 8, 2026

Uh oh!

mgorny commented Jan 14, 2026

Uh oh!

mgorny commented Jan 14, 2026

Uh oh!

carterbox commented Jan 14, 2026

Uh oh!

mgorny commented Jan 14, 2026

Uh oh!

carterbox commented Jan 14, 2026

Uh oh!

mgorny commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

conda-forge-admin commented Dec 9, 2025 •

edited

Loading