Bump onnxruntime to 1.24.4 and add Python 3.14#177
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23869425105. Examine the logs at this URL for more detail. |
2d4d184 to
ad3d170
Compare
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23870122707. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23870136963. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/25367859258. Examine the logs at this URL for more detail. |
|
Do we expect the GitHub-hosted runners to be beefy enough to build the CUDA builds? Either way, the cirun ones are still referenced here. I don't think that this is ready, is it? |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
|
conda-forge/admin-requests#1982 provides an alternative for the Linux runners, but I'm not sure what the solution for Windows is, yet. Either way, this PR is not ready to be merged. |
|
Updated to switch Linux builds to Cirrus runners (see also conda-forge/.cirun#174). Windows builds remain on |
|
Is this PR for now just blocked on maintainer approval for the workflow run, or are there other blockers? If it’s just that, can @janjagusch or @cbourjau approve it please? |
|
@jviehhauser would it be possible to activate Relevant comment: #172 (comment). |
|
@diegoferigo-rai Done — removed the skip directive for linux-aarch64 CUDA builds (as per your commit in #172). @conda-forge-admin, please rerender |
|
@jviehhauser please reduce the build matrix to something minmal first (e.g. only python 3.14 and no |
We don't have a way to build for Windows+CUDA, currently. We can't merge this as is. We either have to drop those builds or wait a little longer to see how this is resolved upstream (my preference). |
|
@conda-forge-admin, please rerender |
Would it make sense to drop the currently unavailable platforms for now and reintroduce them later? If resolving this upstream takes several weeks, blocking all other builds seems unnecessary. Updated CUDA linux-aarch64 binaries have already been missing for a while, it would be great to move forward in the meantime. |
|
Hey all, please check conda-forge/admin-requests#2008 for some news about larger runners. Either Namespace or Blacksmith should provide beefy machines for CPU builds across all platforms. Ping me for any questions! |
|
@conda-forge-admin, please rerender |
1 similar comment
|
@conda-forge-admin, please rerender |
|
Upstream runners seem to be sorted out. Let's see if the Windows builds as expected. If so, I'll fan-out to to the full build matrix. |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping The following suggestions might help debug any issues:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/24410596181. Examine the logs at this URL for more detail. |
|
Current status: There still seems to be some issue with the Windows builds. I had to manually edit some generated files to get the build going, which isn't viable, but at least allows us to see if they work otherwise. Cross-referencing the conda-simthy issue: conda-forge/conda-smithy#2527 |
|
Update: Whenever conda-forge/conda-smithy#2529 lands (just merged) in a new release, we should be good to go with this. |
Actually, it turns out that the issue in question only affects Blacksmith runners, not Namespace which is what is used since the latest commit. |
|
Hi, what's the current status of this PR? Sorry to raise this again, but if the issues are limited to a single platform, could we temporarily disable that platform and proceed with the others? It seems unreasonable to keep releases blocked for months over one platform's outstanding issues. |
|
#171 ist almost done and keeps Python 3.10. If I can't fix the remaining issue there tomorrow I'll trigger the build. |
b60300c to
ca79009
Compare
cbourjau
left a comment
There was a problem hiding this comment.
I squashed the commits a bit. This ran through much better than I expected 🚀
|
Thanks, @cbourjau |
|
The commit on https://github.com/conda-forge/onnxruntime-feedstock/actions/runs/25391311054/job/74466252157 Once it finishes we can ping the conda-forge folks to restart it, but it suggests some limits might need to be adjusted |
|
@jviehhauser can you see if you have permissions to restart the job? If not I can spam the conda help-python folks, but maybe now that it's running on GHA (rather than Azure) they have permissions set up to allow it... 🤞 |
|
Thank you @cbourjau, appreciate all your work! 🚀 |
Summary
>= 3.11)cirun-openstack-cpu-4xlargeto Cirrus runners (ghcr.io/cirruslabs/ubuntu-runner-amd64:24.04-lg)self_hostedfromconda-forge.yml(fixes linter warning)Motivation
The Python 3.14 migration PR (#163) was blocked by a segfault in onnxruntime on Python 3.14 (upstream issue microsoft/onnxruntime#27392). This was fixed upstream in v1.24.3 via microsoft/onnxruntime#27413 (refcount bug in map input conversion). The reporter confirmed the fix on win-64, linux-64, and osx-arm64.
v1.24.4 is a patch release containing additional bug fixes. It also bumps
python_requiresto>= 3.11, so Python 3.10 is dropped from the build matrix.All 4 existing patches were verified to still apply cleanly to v1.24.4.
CI runner changes
The Quansight Open GPU Server (OpenStack) was decommissioned on 2026-03-13 (conda-forge/.cirun#174), causing all Linux GHA jobs to time out after 24h waiting for runners that no longer exist. This PR switches Linux builds to Cirrus runners (access granted via conda-forge/admin-requests#1982). Windows builds remain on
cirun-azure-windows-4xlarge.Supersedes #163 and #176.
Test plan