Update to 1.24.3 and enable "megabuild"#175
Closed
cbourjau wants to merge 3 commits into
Closed
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/23050247857. Examine the logs at this URL for more detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A less ambitious version #171
Inspired by the pytorch feedstock the idea is to build the expensive part once and then to reuse the build-artifacts to cheaply build the Python bindings using the upstream static-linking. I tried dynamic linking in #171, but failed. The bindings call many internal functions not defined in the C-API. I managed to expose those in a hacky way on Unix, but failed on Windows.
One extra challenge in this feedstock compared to pytorch is that the vendored onnx-dependency recreates binding files for protobuf which invalidates large parts of the build cache. That invalidation kicks in for every second output.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)