Skip to content

Conversation

@traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 3, 2025

Fix #320 using solution S1 from #320 (comment), as anyhow the coordination_agent_recoverable flag is not documented or reference anyway, so I doubt it is problematic for user not having it.

Fix #293, I integrated the solution in an existing PR to avoid duplicating the package built and the CI usage.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro changed the title Remove coordination_agent_recoverable from xla to avoid crash on CUDA plugin load Remove coordination_agent_recoverable from xla to avoid crash on CUDA plugin load and fix packages listed as pypi-installed Sep 3, 2025
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Sep 3, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17493487131. Examine the logs at this URL for more detail.

@traversaro
Copy link
Contributor Author

I already built locally and I verified that the build fix both references issues.

@traversaro
Copy link
Contributor Author

cirun does not want to run even if I am an enabled user (perhaps I need to be a mantainer of the feedstock?), anyhow the PR is ready for review. @conda-forge/jaxlib

@xhochy
Copy link
Member

xhochy commented Sep 8, 2025

OSX build repeatably time out :(

@h-vetinari
Copy link
Member

Might have to follow along the same path as conda-forge/tensorflow-feedstock#442

@xhochy
Copy link
Member

xhochy commented Sep 8, 2025

Yes, that is a long-term solution. @h-vetinari Would you be OK with merging here, as this doesn't affect OSX at all? I'm happy to provide local OSX builds until conda-forge/tensorflow-feedstock#442 works, but in this case, it doesn't seem to be necessary.

@h-vetinari h-vetinari merged commit 3180061 into conda-forge:main Sep 8, 2025
16 of 19 checks passed
@h-vetinari
Copy link
Member

Thanks @traversaro! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants