Skip to content

faiss-split v1.11.0#88

Closed
regro-cf-autotick-bot wants to merge 2 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:1.11.0_hd8023e
Closed

faiss-split v1.11.0#88
regro-cf-autotick-bot wants to merge 2 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:1.11.0_hd8023e

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #83

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/14668640989 - please use this URL for debugging.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.
  • ℹ️ faiss output has some malformed specs:
  • In section host: libfaiss =1.11.0=*_cuda
  • In section run: libfaiss =1.11.0=*_cuda
  • In section test: libblas =*=*mkl
    faiss-cpu output has some malformed specs:
  • In section run: faiss =1.11.0=*_cpu
    faiss-gpu output has some malformed specs:
  • In section run: faiss =1.11.0=*_cuda
    Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8 should be python >=3.8.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14668827448. Examine the logs at this URL for more detail.

@mikemccand
Copy link
Copy Markdown

It would be awesome to have Faiss 1.11.0 distributed through conda-forge channel ...

I peeked at one of the full log files above for root cause:

2025-04-25T16:24:45.2648751Z Source cache directory is: /home/conda/feedstock_root/build_artifacts/src_cache
2025-04-25T16:24:45.2653183Z Downloading source to cache: v1.11.0_c5d517da6d.tar.gz
2025-04-25T16:24:45.2653493Z Downloading https://github.com/facebookresearch/faiss/archive/v1.11.0.tar.gz
2025-04-25T16:24:45.5065096Z Success
2025-04-25T16:24:45.5106892Z Extracting download
2025-04-25T16:24:45.7646678Z Applying patch: /home/conda/recipe_root/patches/0001-adapt-header-target-directory-to-outputname.patch
2025-04-25T16:24:45.7752916Z Applying patch: /home/conda/recipe_root/patches/0001-adapt-header-target-directory-to-outputname.patch with args:
2025-04-25T16:24:45.7754387Z ['-Np1', '-i', '/tmp/tmpfo998wxo/0001-adapt-header-target-directory-to-outputname.patch.native', '--binary']
2025-04-25T16:24:45.7772703Z checking file faiss/CMakeLists.txt
2025-04-25T16:24:45.7773750Z Hunk #1 FAILED at 233.
2025-04-25T16:24:45.7774114Z Hunk #2 succeeded at 407 (offset 34 lines).
2025-04-25T16:24:45.7774312Z Hunk #3 succeeded at 453 (offset 41 lines).
2025-04-25T16:24:45.7774644Z Hunk #4 succeeded at 470 (offset 41 lines).
2025-04-25T16:24:45.7774854Z 1 out of 4 hunks FAILED
2025-04-25T16:24:45.7775036Z checking file faiss/gpu/CMakeLists.txt
2025-04-25T16:24:45.7775261Z Hunk #1 succeeded at 316 with fuzz 2 (offset 10 lines).
2025-04-25T16:24:45.7786916Z Warning: failed to download source.  If building, will try again after downloading recipe dependencies.
2025-04-25T16:24:45.7788299Z Error was: 
2025-04-25T16:24:45.7790262Z Command '['/opt/conda/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmpfo998wxo/0001-adapt-header-target-directory-to-outputname.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.
2025-04-25T16:24:45.7792041Z Traceback (most recent call last):
2025-04-25T16:24:45.7792807Z   File "/opt/conda/bin/conda-build", line 11, in <module>
2025-04-25T16:24:45.7798371Z     sys.exit(execute())
2025-04-25T16:24:45.7798661Z              ^^^^^^^^^
2025-04-25T16:24:45.7798871Z   File "/opt/conda/lib/python3.12/site-packages/conda_build/cli/main_build.py", line 622, in execute
2025-04-25T16:24:45.7804188Z     api.build(
2025-04-25T16:24:45.7804584Z   File "/opt/conda/lib/python3.12/site-packages/conda_build/api.py", line 211, in build
2025-04-25T16:24:45.7807694Z     return build_tree(
2025-04-25T16:24:45.7810230Z            ^^^^^^^^^^^
2025-04-25T16:24:45.7810528Z   File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 3664, in build_tree
2025-04-25T16:24:45.7825600Z     packages_from_this = build(
2025-04-25T16:24:45.7829089Z                          ^^^^^^
2025-04-25T16:24:45.7830721Z   File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 2456, in build
2025-04-25T16:24:45.7831038Z     try_download(m, no_download_source=False, raise_error=True)
2025-04-25T16:24:45.7831318Z   File "/opt/conda/lib/python3.12/site-packages/conda_build/render.py", line 852, in try_download
2025-04-25T16:24:45.7840010Z     raise RuntimeError(
2025-04-25T16:24:45.7840444Z RuntimeError: Failed to download or patch source. Please see build log for info.

It looks like the patch (/home/conda/recipe_root/patches/0001-adapt-header-target-directory-to-outputname.patch) is stale and doesn't apply cleanly to Faiss's sources? But I know nothing about the context here, what this patch is trying to do, etc.

@traversaro
Copy link
Copy Markdown

Hi @mikemccand ! Just to let you know, you can mention the mantainer of the feedstock with @conda-forge/faiss-split .

@h-vetinari
Copy link
Copy Markdown
Member

you can mention the mantainer of the feedstock with @conda-forge/faiss-split

That would be me. I don't have much time for faiss at the moment. I tried to get 1.10 ready a while ago, but ran into problems, see #83. Feel free to pick up that PR and add some fixes.

@weiji14
Copy link
Copy Markdown
Member

weiji14 commented Mar 19, 2026

I'm gonna rebase this on top of #83, and also work to pull in CUDA 13 (#97) and Python 3.14 (#92) + more.

Edit: great, wasn't quick enough 😅. Will put things into the new PR when that pops up.

@weiji14 weiji14 mentioned this pull request Mar 19, 2026
@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor Author

I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. You should expect to wait at least a few hours, or possibly much longer, for a new PR.

This was generated by https://github.com/regro/cf-scripts/actions/runs/23316529544 - please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.11.0_hd8023e branch March 19, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants