-
-
Notifications
You must be signed in to change notification settings - Fork 21
faiss-split v1.10.0 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weiji14
merged 48 commits into
conda-forge:main
from
regro-cf-autotick-bot:1.10.0_hb2f3eb
Mar 19, 2026
Merged
Changes from 5 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
9888322
updated v1.10.0
regro-cf-autotick-bot 53a2065
MNT: Re-rendered with conda-build 25.1.1, conda-smithy 3.45.4, and co…
regro-cf-autotick-bot 05b7e32
rebase patches
h-vetinari b8c2f1b
also build faiss_example_external_module
h-vetinari 4a41d69
MNT: Re-rendered with conda-build 25.1.2, conda-smithy 3.47.0, and co…
b57f4da
Update recipe/meta.yaml
hmaarrfk ce28bde
add mkl/generic builds
hmaarrfk 0a15f92
build mkl/non-mkl variants
hmaarrfk fc981fe
MNT: Re-rendered with conda-build 25.1.2, conda-smithy 3.47.0, and co…
edcf74c
remote test.
hmaarrfk 0abaad3
MNT: Re-rendered with conda-smithy 3.56.3 and conda-forge-pinning 202…
weiji14 ac23e51
Remove CUDA 11.8 skip
weiji14 5fda235
Set Python_NumPy_INCLUDE_DIR to $SP_DIR/numpy/_core/include for NumPy 2
weiji14 5a2e6a2
Skip tests failing on NumPy 2
weiji14 68d0c28
Merge branch 'main' into 1.10.0_hb2f3eb
weiji14 77c8d6a
Update doc_url to https://faiss.ai/
weiji14 30cfa03
Tidy up BLAS and OpenMP variant handling
weiji14 fd33e44
MNT: Re-rendered with conda-smithy 3.56.3 and conda-forge-pinning 202…
weiji14 54dcc59
More blas and openmp cleanups
weiji14 2379e0e
Remove conda_build_config.yaml with blas_impl settings
weiji14 34899b4
MNT: Re-rendered with conda-smithy 3.56.3 and conda-forge-pinning 202…
weiji14 9661464
Skip some more tests on Windows
weiji14 4c6d820
Replace libblas, libcblas, liblapack, mkl-devel, etc with blas-devel
weiji14 e2b2d63
MNT: Re-rendered with conda-smithy 3.56.3 and conda-forge-pinning 202…
weiji14 198d79b
Set proper build regex with blas_impl for blas-devel
weiji14 86736f0
Set FAISS_ENABLE_GPU env variable properly
weiji14 2c551c4
Skip windows CUDA builds
weiji14 e5a67ae
MNT: Re-rendered with conda-smithy 3.56.3 and conda-forge-pinning 202…
weiji14 a4b76f1
Skip some more tests on win and osx
weiji14 ff7670f
Don't build faiss_example_external_module
weiji14 644aa82
Add intel-openmp for win + mkl build
weiji14 7fade5d
Revert "Don't build faiss_example_external_module"
weiji14 81d61b8
Remove win selector on libcublas-dev
weiji14 05e92b5
Temporarily build for CUDA_ARCH 86 only
weiji14 b163646
Skip tests that segfault on Linux + CUDA or Windows + MKL
weiji14 83e87d3
Merge branch 'main' into 1.10.0_hb2f3eb
weiji14 e4262a9
lint
weiji14 d1add10
Prefix proc_type and include blas_impl in build string
weiji14 7426174
Skip more segfaulting tests on linux and windows
weiji14 24a0c39
Move intel-openmp to libfaiss's host deps
weiji14 428a985
Comment out test skips under windows + mkl + no cuda
weiji14 182b4f2
Try using _openmp_mutex instead of llvm-openmp or intel-openmp
weiji14 b902b2c
Just use llvm-openmp for all platforms
weiji14 5c11583
Use llvm-openmp for osx and linux, libgomp for win
weiji14 d478021
Revert back to intel-openmp on win+mkl and reinstate test skips
weiji14 ea7d0a3
Skip WIndows + MKL builds for now
weiji14 cb670b4
MNT: Re-rendered with conda-smithy 3.57.0 and conda-forge-pinning 202…
weiji14 482ebfb
Revert "Temporarily build for CUDA_ARCH 86 only"
weiji14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,25 @@ | ||
| From b10e7de1831aeb28348b55383c3e139eac9ede00 Mon Sep 17 00:00:00 2001 | ||
| From 0887bdb21ebdc9e98753aa4fa97c6bc68ed44810 Mon Sep 17 00:00:00 2001 | ||
| From: "H. Vetinari" <[email protected]> | ||
| Date: Sun, 14 Feb 2021 15:52:27 +0100 | ||
| Subject: [PATCH 01/13] adapt header target directory to outputname | ||
| Subject: [PATCH 01/11] adapt header target directory to outputname | ||
|
|
||
| --- | ||
| faiss/CMakeLists.txt | 20 ++++++++++++++++---- | ||
| faiss/gpu/CMakeLists.txt | 9 ++++++++- | ||
| 2 files changed, 24 insertions(+), 5 deletions(-) | ||
|
|
||
| diff --git a/faiss/CMakeLists.txt b/faiss/CMakeLists.txt | ||
| index 2871d9747..fbd17a23b 100644 | ||
| index 6e9eb883..99d8285e 100644 | ||
| --- a/faiss/CMakeLists.txt | ||
| +++ b/faiss/CMakeLists.txt | ||
| @@ -233,9 +233,14 @@ endif() | ||
| @@ -242,9 +242,14 @@ endif() | ||
| set(FAISS_HEADERS ${FAISS_HEADERS} PARENT_SCOPE) | ||
|
|
||
| add_library(faiss ${FAISS_SRC}) | ||
| +set_target_properties(faiss PROPERTIES OUTPUT_NAME "faiss") | ||
|
|
||
| add_library(faiss_avx2 ${FAISS_SRC}) | ||
| -if(NOT FAISS_OPT_LEVEL STREQUAL "avx2" AND NOT FAISS_OPT_LEVEL STREQUAL "avx512") | ||
| -if(NOT FAISS_OPT_LEVEL STREQUAL "avx2" AND NOT FAISS_OPT_LEVEL STREQUAL "avx512" AND NOT FAISS_OPT_LEVEL STREQUAL "avx512_spr") | ||
| +set_target_properties(faiss_avx2 PROPERTIES OUTPUT_NAME "faiss_avx2") | ||
| + | ||
| +if(FAISS_OPT_LEVEL STREQUAL "avx2") | ||
|
|
@@ -28,7 +28,7 @@ index 2871d9747..fbd17a23b 100644 | |
| set_target_properties(faiss_avx2 PROPERTIES EXCLUDE_FROM_ALL TRUE) | ||
| endif() | ||
| if(NOT WIN32) | ||
| @@ -373,6 +378,13 @@ else() | ||
| @@ -394,6 +399,13 @@ else() | ||
| target_link_libraries(faiss_sve PRIVATE ${LAPACK_LIBRARIES}) | ||
| endif() | ||
|
|
||
|
|
@@ -42,7 +42,7 @@ index 2871d9747..fbd17a23b 100644 | |
| install(TARGETS faiss | ||
| EXPORT faiss-targets | ||
| RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} | ||
| @@ -405,7 +417,7 @@ endif() | ||
| @@ -433,7 +445,7 @@ endif() | ||
| foreach(header ${FAISS_HEADERS}) | ||
| get_filename_component(dir ${header} DIRECTORY ) | ||
| install(FILES ${header} | ||
|
|
@@ -51,7 +51,7 @@ index 2871d9747..fbd17a23b 100644 | |
| ) | ||
| endforeach() | ||
|
|
||
| @@ -422,9 +434,9 @@ configure_file(${PROJECT_SOURCE_DIR}/cmake/faiss-config.cmake.in | ||
| @@ -450,9 +462,9 @@ configure_file(${PROJECT_SOURCE_DIR}/cmake/faiss-config.cmake.in | ||
| ) | ||
| install(FILES ${PROJECT_BINARY_DIR}/cmake/faiss-config.cmake | ||
| ${PROJECT_BINARY_DIR}/cmake/faiss-config-version.cmake | ||
|
|
@@ -64,11 +64,11 @@ index 2871d9747..fbd17a23b 100644 | |
| + DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/${libname} | ||
| ) | ||
| diff --git a/faiss/gpu/CMakeLists.txt b/faiss/gpu/CMakeLists.txt | ||
| index b84362266..8a3cc36ef 100644 | ||
| index 16574aab..bcd8a137 100644 | ||
| --- a/faiss/gpu/CMakeLists.txt | ||
| +++ b/faiss/gpu/CMakeLists.txt | ||
| @@ -306,10 +306,17 @@ target_link_libraries(faiss_avx2 PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,faiss_gpu | ||
| target_link_libraries(faiss_avx512 PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,faiss_gpu>") | ||
| @@ -309,10 +309,17 @@ target_link_libraries(faiss_avx512 PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,faiss_g | ||
| target_link_libraries(faiss_avx512_spr PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,faiss_gpu>") | ||
| target_link_libraries(faiss_sve PRIVATE "$<LINK_LIBRARY:WHOLE_ARCHIVE,faiss_gpu>") | ||
|
|
||
| +# to distinguish between faiss and faiss_avx2 | ||
|
|
||
6 changes: 3 additions & 3 deletions
6
recipe/patches/0002-skip-test_stress-for-GPU-on-windows.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,14 @@ | ||
| From ad8cbb02c90f10b5222498024b0000d96dd432df Mon Sep 17 00:00:00 2001 | ||
| From e3dcf950cfbb74b9997252e115377bfdf1cb6811 Mon Sep 17 00:00:00 2001 | ||
| From: "H. Vetinari" <[email protected]> | ||
| Date: Fri, 19 Feb 2021 14:14:31 +0100 | ||
| Subject: [PATCH 02/13] skip test_stress for GPU on windows | ||
| Subject: [PATCH 02/11] skip test_stress for GPU on windows | ||
|
|
||
| --- | ||
| faiss/gpu/test/test_gpu_basics.py | 2 ++ | ||
| 1 file changed, 2 insertions(+) | ||
|
|
||
| diff --git a/faiss/gpu/test/test_gpu_basics.py b/faiss/gpu/test/test_gpu_basics.py | ||
| index 4b4024d23..0798c7f6a 100755 | ||
| index 0156e842..cf9328cc 100755 | ||
| --- a/faiss/gpu/test/test_gpu_basics.py | ||
| +++ b/faiss/gpu/test/test_gpu_basics.py | ||
| @@ -6,6 +6,7 @@ | ||
|
|
||
8 changes: 4 additions & 4 deletions
8
recipe/patches/0003-enable-building-libfaiss_avx2-without-libfaiss.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| From e7d62b3d0d33d9538b7c83e4abbdd00919868a2a Mon Sep 17 00:00:00 2001 | ||
| From 2b62a2fe546d13bf06720088c8ce00a6c9931b6c Mon Sep 17 00:00:00 2001 | ||
| From: "H. Vetinari" <[email protected]> | ||
| Date: Wed, 2 Jun 2021 22:58:19 +0200 | ||
| Subject: [PATCH 03/13] enable building libfaiss_avx2 without libfaiss | ||
| Subject: [PATCH 03/11] enable building libfaiss_avx2 without libfaiss | ||
|
|
||
| --- | ||
| faiss/CMakeLists.txt | 19 +++++++++++-------- | ||
| 1 file changed, 11 insertions(+), 8 deletions(-) | ||
|
|
||
| diff --git a/faiss/CMakeLists.txt b/faiss/CMakeLists.txt | ||
| index fbd17a23b..53e27d3f1 100644 | ||
| index 99d8285e..ffab1189 100644 | ||
| --- a/faiss/CMakeLists.txt | ||
| +++ b/faiss/CMakeLists.txt | ||
| @@ -385,18 +385,21 @@ else() | ||
| @@ -406,18 +406,21 @@ else() | ||
| get_target_property(libname faiss OUTPUT_NAME) | ||
| endif() | ||
|
|
||
|
|
||
8 changes: 4 additions & 4 deletions
8
recipe/patches/0004-increase-tolerance-for-marginally-failing-test.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| From d47fbe5168ec7c1b5732f3c945bd907de055bbbb Mon Sep 17 00:00:00 2001 | ||
| From 7f0beb401d2639c5696644adee3219b7eb8dbcbe Mon Sep 17 00:00:00 2001 | ||
| From: "H. Vetinari" <[email protected]> | ||
| Date: Sat, 5 Jun 2021 01:45:14 +0200 | ||
| Subject: [PATCH 04/13] increase tolerance for marginally failing test | ||
| Subject: [PATCH 04/11] increase tolerance for marginally failing test | ||
|
|
||
| --- | ||
| tests/test_residual_quantizer.py | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| diff --git a/tests/test_residual_quantizer.py b/tests/test_residual_quantizer.py | ||
| index f4381607e..0ce4cffd2 100644 | ||
| index c9ae4090..a640a8d7 100644 | ||
| --- a/tests/test_residual_quantizer.py | ||
| +++ b/tests/test_residual_quantizer.py | ||
| @@ -677,7 +677,7 @@ class TestAdditiveQuantizerWithLUT(unittest.TestCase): | ||
| @@ -708,7 +708,7 @@ class TestAdditiveQuantizerWithLUT(unittest.TestCase): | ||
| norms = np.zeros(1 << aq.tot_bits, dtype="float32") | ||
| aq.compute_centroid_norms(sp(norms)) | ||
|
|
||
|
|
||
8 changes: 4 additions & 4 deletions
8
recipe/patches/0005-add-bigobj-to-swigfaiss-compile-options-on-windows.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| From 78882cdef9eb9c25557460a7f94dcd0067914ff3 Mon Sep 17 00:00:00 2001 | ||
| From accd9b17d5b53c05c600498d982834cdb6bc686d Mon Sep 17 00:00:00 2001 | ||
| From: "H. Vetinari" <[email protected]> | ||
| Date: Sat, 5 Jun 2021 16:29:53 +0200 | ||
| Subject: [PATCH 05/13] add /bigobj to swigfaiss compile options on windows | ||
| Subject: [PATCH 05/11] add /bigobj to swigfaiss compile options on windows | ||
|
|
||
| --- | ||
| faiss/python/CMakeLists.txt | 2 ++ | ||
| 1 file changed, 2 insertions(+) | ||
|
|
||
| diff --git a/faiss/python/CMakeLists.txt b/faiss/python/CMakeLists.txt | ||
| index aea99af79..298725701 100644 | ||
| index 3fc46f4c..ec8cfd0a 100644 | ||
| --- a/faiss/python/CMakeLists.txt | ||
| +++ b/faiss/python/CMakeLists.txt | ||
| @@ -33,6 +33,8 @@ macro(configure_swigfaiss source) | ||
| @@ -32,6 +32,8 @@ macro(configure_swigfaiss source) | ||
| set_source_files_properties(${source} PROPERTIES | ||
| SWIG_FLAGS -DSWIGWIN | ||
| ) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| From f155504480573b6e66cc97f4bd665f0590a653bb Mon Sep 17 00:00:00 2001 | ||
| From bd0e39e64d0dd7a81f0129f790ee695fb396a0fe Mon Sep 17 00:00:00 2001 | ||
| From: "H. Vetinari" <[email protected]> | ||
| Date: Thu, 25 May 2023 22:29:29 +1100 | ||
| Subject: [PATCH 06/13] no more Release/ subfolder | ||
| Subject: [PATCH 06/11] no more Release/ subfolder | ||
|
|
||
| --- | ||
| faiss/python/setup.py | 2 +- | ||
| 1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
|
||
| diff --git a/faiss/python/setup.py b/faiss/python/setup.py | ||
| index 46cacc051..68945531a 100644 | ||
| index 23611cb3..4745b970 100644 | ||
| --- a/faiss/python/setup.py | ||
| +++ b/faiss/python/setup.py | ||
| @@ -21,7 +21,7 @@ shutil.copyfile("extra_wrappers.py", "faiss/extra_wrappers.py") | ||
| @@ -23,7 +23,7 @@ shutil.copyfile("extra_wrappers.py", "faiss/extra_wrappers.py") | ||
| shutil.copyfile("array_conversions.py", "faiss/array_conversions.py") | ||
|
|
||
| ext = ".pyd" if platform.system() == 'Windows' else ".so" | ||
| -prefix = "Release/" * (platform.system() == 'Windows') | ||
| ext = ".pyd" if platform.system() == "Windows" else ".so" | ||
| -prefix = "Release/" * (platform.system() == "Windows") | ||
| +prefix = "" | ||
|
|
||
| swigfaiss_generic_lib = f"{prefix}_swigfaiss{ext}" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.