Add migrator for CUDA on Windows #914
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/migrations/window_cuda.yaml
Outdated
| - gcc # [linux] | ||
| - clang # [osx] | ||
| # part of a zip_keys: c_compiler, cxx_compiler, cuda_compiler_version | ||
| - vs2015 # [win] |
There was a problem hiding this comment.
That will simplify the migration, but unfortunately it'll mean that CUDA 9.2 won't get support on Windows :/
There was a problem hiding this comment.
True, but @conda-forge/core made a decision to stop supporting it and going back is not possible without rebuilding all of the dependencies of a package needing CUDA 9.2.
There was a problem hiding this comment.
The CUDA 9.2 headers could be patched, but that doesn't look like a good idea.
There was a problem hiding this comment.
Technically you can make it work by installing vc140 toolchain inside VS2017 and making sure vs2015_win-64 use the VS2017 installation of vc140.
|
Is there anything else to be added here? |
|
I think this looks ok, would you be able to baby sit things for a bit? |
|
Babysitting as in helping other repos set up their Windows integrations? |
|
More as in, watch the PRs the bot makes for this, if they seem incorrect (either in the build or the order) ping us and open a revert PR (or fix the migrator). |
|
Sure, that I can do! |
|
@isuruf is ok by you? |
|
Thanks for working on this Jaime! 😄 |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)PR created in the context of bringing
nvccon Windows. Related PRs: