ENH : sort activate.d scripts to control order #66
Conversation
Sort the found shell scripts to allow the user to control which order the scripts are run in.
|
@tswicegood I was in the process of making sure my PR message was sensible. How did you even notice that commit existed? |
|
Spoke too soon on the commit! Here's the PR. I saw it existed because I happened to be looking at the network graph and see your commit out there by itself. This change makes perfect sense, though I would like to get it into the Windows side too if possible. I think we need to switch it up to use |
|
I have not used a windows box for anything but video games in almost a decade now. I can try to make changes, but don't have anyway to test if they even run.... It looks like there is already an asymmetry, on the *nix side it will find all |
|
Is that necessary? I tested the current Windows implementation locally and it looks like |
|
testing this again, it looks like |
|
Worth noting that the current Windows implementation does not look into subdirectories: X:\conda-env\conda_env : $ for %%g in (*.py) do echo "%%g"
"compat.py"
"env.py"
"exceptions.py"
"print_env.py"
"yaml.py"
"__init__.py"While unix does (I'm using your [dev@localhost conda_env]$ for f in $(find . -name "*.py" | sort); do echo $f; done
./cli/__init__.py
./cli/main_create.py
./cli/main_export.py
./cli/main_list.py
./cli/main.py
./cli/main_remove.py
./cli/main_update.py
./cli/main_upload.py
./compat.py
./env.py
./exceptions.py
./__init__.py
./installers/base.py
./installers/conda.py
./installers/__init__.py
./installers/pip.py
./print_env.py
./specs/binstar.py
./specs/__init__.py
./specs/yaml_file.py
./utils/__init__.py
./utils/uploader.py
./yaml.py |
|
That's a good find, @campos-ddc. The intended behavior is to only go one level so a |
|
@tacaswell I'm not sure if I understand what is the intention of this PR |
|
If you have a collection of packages which need to activation scripts run and there is some interdependency on that order. Ex This is inspired by how the |
Sort the found shell scripts to allow the user to control which order
the scripts are run in.
I don't know enough to make the parallel change in the windows files.
The reason I want this is because I am trying to use conda packages to manage the setup/teardown of a test environment where I need to start a server-like thing, but some environmental variables need to be set first.
It currently sorts on the path to the scripts which is fine if you don't have anything in directories. I am not convinced that this is not the desired behavior, just aware of the concern.