fix(set_pipeline): evaluate InstanceVars ahead of other variables #9362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test demonstrates the current broken behaviour. Signed-off-by: Adam Eijdenberg <[email protected]>
during set_pipeline Signed-off-by: Adam Eijdenberg <[email protected]>
analytically
approved these changes
Nov 17, 2025
Member
|
Thanks for the PR! Adding it to my backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #9356
Notes to reviewer
It's a shame the code used for
fly set-pipelineand theset_pipelinestep seem quite divergent - but that feels like a much bigger PR to look at, so this makes a smaller change to address the reported issue.Release Note
set_pipelinestep now allowsinstance_varsto override vars set viavars/var_file. This matches the behaviour offly set-pipeline