perf: optimize countingWaitGroup for faster Count() operations#9162
Closed
analytically wants to merge 1 commit intoconcourse:masterfrom
analytically:waitgroupatomic
Closed
perf: optimize countingWaitGroup for faster Count() operations#9162analytically wants to merge 1 commit intoconcourse:masterfrom analytically:waitgroupatomic
analytically wants to merge 1 commit intoconcourse:masterfrom
analytically:waitgroupatomic
Conversation
Improve performance of the countingWaitGroup implementation while maintaining the original behavior: - Use atomic.Int64 for the counter to enable lock-free Count() reads - Keep mutex synchronization for Add() and Done() to ensure atomicity between WaitGroup operations and counter updates - Significantly reduce contention when multiple goroutines read the count while operations are in progress This change improves performance when the beacon rebalancing logic frequently checks the Count() value. Signed-off-by: Mathias Bogaert <mathias.bogaert@gmail.com>
analytically
changed the title
Member
|
The Beacon rebalance operation is called every 4hrs by default. Not exactly "frequent". concourse/worker/workercmd/worker.go Line 48 in a84c738 Going to leave the code as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance of the countingWaitGroup implementation while
maintaining the original behavior:
between WaitGroup operations and counter updates
while operations are in progress
This change improves performance when the beacon rebalancing logic
frequently checks the Count() value.