allow for inline ouput using additional pipe param #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vknabel
reviewed
Dec 6, 2019
Comment on lines
+9
to
+11
| public transform(markdown: string, options?: MarkedOptions, inline?: boolean): string { | ||
| if (markdown == null) return ''; | ||
| return marked(markdown, options); | ||
| return (inline) ? marked.inlineLexer(markdown, [], options) : marked(markdown, options); |
There was a problem hiding this comment.
Thanks for your contribution!
Could you wrap inline into an object?
It think { inline: true } is much more expressive
[innerHTML]="t.text || t.full_text | MarkdownToHtml:{}:{inline: true}"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional arg so the user can use the inlineLexer to prevent the output of the p parameter. I'm new to the world of pipes but figured this might be the best way to do it.
So an example with the additional argument would be:
[innerHTML]="t.text || t.full_text | MarkdownToHtml:{}:true"I'm adding this functionality because I am leveraging your functionality in one of my projects and could use it as well.