Conversation
|
@SimonGreenhill Is the PR ready for review? If so, I’d be happy to take on the role of moderator. |
|
yes please! |
|
Okay, great! @alzkuc and @MiraAhmedovic Would you have time to review this PR? |
Hi @AnnikaTjuka! |
|
I'm also happy to take a look today! |
alzkuc
left a comment
alzkuc
left a comment
There was a problem hiding this comment.
Hi @SimonGreenhill, I have left a few comments and suggestions on your files. Take a look whenever you have the time.
MiraAhmedovic
left a comment
MiraAhmedovic
left a comment
There was a problem hiding this comment.
Thank you for adding this list! I've left a few comments, please let me know if anything is unclear.
|
Thanks for the reviews @alzkuc and @MiraAhmedovic! @SimonGreenhill Thanks for implementing the changes and replying to the comments! If you merge the master branch and resolve the conflicts, I'll take a final look and approve the PR so that it can be merged. |
|
thanks Annika -- conflicts fixed and I think I've got all the requested changes now. |
|
It seems that the Concepticon checks failed, so the merge has apparently caused some inconsistencies. |
|
ERROR:Huisman-2025-255: wrong conceptset GLOSS for ID 810: BREATH -> LOCUST |
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Great, looks good now!
|
@alzkuc and @MiraAhmedovic Could you please approve the requested changes so that we can merge this PR? |
MiraAhmedovic
left a comment
MiraAhmedovic
left a comment
There was a problem hiding this comment.
Just one minor thing to be changed still.
Sorry about the BREATH ID mismatch! Thank you for fixing that.
|
Thanks @SimonGreenhill ! @MiraAhmedovic and @alzkuc Could you please approve your requested changes? We can't merge the PR without your approval. |
4 participants
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
Note the paper says 256 concepts but I can only find 255.