Fix PVC race in teardown by draining pods before deletion#33
Merged
Conversation
The old teardown deleted deployments and PVCs concurrently with --wait=false, so PVCs got stuck in Terminating while pods still held volume mounts. Scale deployments to zero and wait for pods to drain before deleting PVCs with --wait=true. Remove retry loops, verification queries, and remaining-resource reporting — let CI handle retries if anything fails. Assisted-by: Claude Opus 4.6 Signed-off-by: Trevor Vaughan <tvaughan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old teardown deleted deployments and PVCs concurrently with
--wait=false, so PVCs got stuck in Terminating while pods still
held volume mounts.
Scale deployments to zero and wait for pods to drain before
deleting PVCs with --wait=true. Remove retry loops, verification
queries, and remaining-resource reporting — let CI handle retries
if anything fails.
Assisted-by: Claude Opus 4.6
Signed-off-by: Trevor Vaughan tvaughan@redhat.com