Replace Skaffold-dependent teardown with label-based discovery#31
Merged
Conversation
The sk:delete task previously required the generated overlay directory to exist so skaffold delete could re-render manifests. This broke on stage/prod when the directory was missing (different CI runner, expired artifacts). The new approach queries the namespace for resources labelled app.kubernetes.io/managed-by=skaffold and deletes them directly, then separately cleans up PVCs. After deletion it reports both what was torn down and what was preserved (secrets, non-Skaffold ConfigMaps) so operators can manually finish cleanup. - Extract teardown logic into scripts/lib/teardown.sh (same sourceable pattern as grafana-url.sh) - Update sk:delete to source and call teardown_namespace() - Add 10 bats tests covering: label-based deletion, PVC handling, preserved-resource reporting, empty namespace, overlay cleanup, NAMESPACE validation Assisted-by: Claude Opus 4.6 Signed-off-by: Trevor Vaughan <tvaughan@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sk:delete task previously required the generated overlay directory
to exist so skaffold delete could re-render manifests. This broke on
stage/prod when the directory was missing (different CI runner, expired
artifacts).
The new approach queries the namespace for resources labelled
app.kubernetes.io/managed-by=skaffold and deletes them directly,
then separately cleans up PVCs. After deletion it reports both what
was torn down and what was preserved (secrets, non-Skaffold ConfigMaps)
so operators can manually finish cleanup.
pattern as grafana-url.sh)
preserved-resource reporting, empty namespace, overlay cleanup,
NAMESPACE validation
Assisted-by: Claude Opus 4.6
Signed-off-by: Trevor Vaughan tvaughan@redhat.com