Skip to content

Add Emscripten build of CppInterOp on Windows #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Apr 21, 2025

Description

Please include a summary of changes, motivation and context for this PR.

This PR makes it so CppInterOp can be compiled to Emscripten on Windows.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (da58066) to head (5fe4b1d).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   76.16%   76.27%   +0.10%     
==========================================
  Files           9        9              
  Lines        3655     3650       -5     
==========================================
  Hits         2784     2784              
+ Misses        871      866       -5     

see 1 file with indirect coverage changes

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton force-pushed the Windows-emscripten-build branch 5 times, most recently from 240f7c2 to f38d280 Compare April 24, 2025 13:52
@mcbarton mcbarton force-pushed the Windows-emscripten-build branch from 7f3110e to 5fe4b1d Compare April 24, 2025 16:01
@mcbarton mcbarton changed the title [wip] Add Emscripten build of CppInterOp on Windows Add Emscripten build of CppInterOp on Windows Apr 24, 2025
@mcbarton mcbarton marked this pull request as ready for review April 24, 2025 18:11
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton mcbarton merged commit 6975c54 into compiler-research:main Apr 25, 2025
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants