Skip to content

Improve formatting, readability and add newlines #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented Apr 3, 2025

No description provided.

@aaronj0 aaronj0 requested a review from vgvassilev April 3, 2025 08:49
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (5c1e27a) to head (850bdd0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files           9        9           
  Lines        3650     3650           
=======================================
  Hits         2784     2784           
  Misses        866      866           
Files with missing lines Coverage Δ
lib/Interpreter/CXCppInterOp.cpp 48.86% <100.00%> (ø)
Files with missing lines Coverage Δ
lib/Interpreter/CXCppInterOp.cpp 48.86% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Contributor

We generally don’t add white space change PRs. Is there a particular reason to add this one?

@aaronj0
Copy link
Collaborator Author

aaronj0 commented Apr 3, 2025

We generally don’t add white space change PRs. Is there a particular reason to add this one?

While a few changes in the CMake are whitespaces (mostly deletions that won't show up on a blame), a lot of files are not newline terminated, which I think should be addressed. They make reading diffs harder, and is not good practice in terms of POSIX standards.

@aaronj0 aaronj0 force-pushed the format-improvements branch from 8a3748c to 850bdd0 Compare April 23, 2025 14:12
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remove the remaining new line changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants