-
Notifications
You must be signed in to change notification settings - Fork 31
Improve formatting, readability and add newlines #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 76.27% 76.27%
=======================================
Files 9 9
Lines 3650 3650
=======================================
Hits 2784 2784
Misses 866 866
🚀 New features to boost your workflow:
|
clang-tidy review says "All clean, LGTM! 👍" |
We generally don’t add white space change PRs. Is there a particular reason to add this one? |
While a few changes in the CMake are whitespaces (mostly deletions that won't show up on a blame), a lot of files are not newline terminated, which I think should be addressed. They make reading diffs harder, and is not good practice in terms of POSIX standards. |
8a3748c
to
850bdd0
Compare
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please remove the remaining new line changes.
No description provided.