Skip to content

fix dispatcher for rvalue #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
Merged

fix dispatcher for rvalue #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Cppyy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,10 @@ namespace Cppyy {
CPPYY_IMPORT
std::string GetTypeAsString(TCppType_t type);
CPPYY_IMPORT
bool IsRValueReferenceType(TCppType_t type);
Copy link

@vgvassilev vgvassilev Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that better to be getValueKind and returning an enum?

Copy link
Collaborator Author

@Vipul-Cariappa Vipul-Cariappa Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just forwarding to CppInterOp's API here. Ref: https://github.com/compiler-research/CppInterOp/blob/main/lib/CppInterOp/CppInterOp.cpp#L1699-L1707
Also look at compiler-research/cppyy-backend#171

Copy link

@vgvassilev vgvassilev Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix that API, too?

Copy link
Collaborator Author

@Vipul-Cariappa Vipul-Cariappa Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed CppInterOp's API to return an enum. Will merge that PR soon, once the CI is green.
For cppyy, I propose we keep the API like this. Otherwise, we will need to forward the enum from cppyy-backend to CPyCppyy. That may not be the best thing to do.

Copy link

@vgvassilev vgvassilev Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...

CPPYY_IMPORT
bool IsLValueReferenceType(TCppType_t type);
CPPYY_IMPORT
bool IsClassType(TCppType_t type);
CPPYY_IMPORT
bool IsFunctionPointerType(TCppType_t type);
Expand Down
5 changes: 4 additions & 1 deletion src/Dispatcher.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,10 @@ bool CPyCppyy::InsertDispatcher(CPPScope* klass, PyObject* bases, PyObject* dct,
code << "{\n return " << binfo.bname << "::" << mtCppName << "(";
for (Cppyy::TCppIndex_t i = 0; i < nArgs; ++i) {
if (i != 0) code << ", ";
code << "arg" << i;
if (Cppyy::IsRValueReferenceType(Cppyy::GetMethodArgType(method, i)))
code << "std::move(arg" << i << ")";
else
code << "arg" << i;
}
code << ");\n }\n";
}
Expand Down