Repository navigation
cli: conversation edit changes admission settings; a stopped setup says how to finish it - #3098
Merged
Merged
Conversation
…ys how to finish it conversation edit accepts --invite-only true|false and --external-id optional|required|allowlist, mapped to Node's flags by the setup model, changing only what is asked and confirming it by read-back. When the allow-list setting is fixed because participation has started, Node's 409 is reported as xid_allowlist_fixed (exit 5) and never retried. A conversation new that stops partway now says the conversation exists, is closed and invite-only, and lists in data.finish the edit and reopen commands that apply the requested settings. If the first create is refused, nothing was created, so the command reports that refusal and its own exit code instead of exit 7 with an unknown outcome. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observable changes (CLI only, no server change):
polis conversation edit <id>gains--invite-only true|falseand--external-id optional|required|allowlist. Both external-ID flags come from the one typed mapping, so they cannot be set apart; Node's refusal to change the allow-list after a conversation has started is reported plainly and never retried. The allow-list IDs themselves stay with their own commands.polis conversation newstops partway (exit 7), the error now says the conversation exists, is closed and invite-only, and gives the exact commands that finish it with the requested settings (still: never rerunnew).Tests: new mock-server cases in
tests/pass5.rsandtests/setup_flow.rs, each failing against the previous code;scripts/test-polis-cli.shpasses.🤖 Generated with Claude Code