Repository navigation
contracts: the admission model follows Node's external-ID rules again; CI runs the admission table - #3093
Merged
Conversation
Node now checks the external-ID allow-list on every join, vote and comment for any request whose external ID is its identity, before resolving that identity, and treats a changed or unknown external ID, or a token from another owner, as a new identity. The model still predicted that known identities bypass the list and that a changed ID kept its participant: against live Node, 472 of the 2,400 admission cells disagreed. predict() now encodes both rules and all 2,400 cells match. The setup summary and the setup document describe the current behaviour, including seed authority. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
scripts/test-setup-admission.sh generates the contract's predictions for every entry path, action and setting, runs the observer against the sealed local Node stack, and fails on any mismatch. It reuses the images the CLI comparison builds, and the comparison workflow now runs it after the command comparison. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018NVGBuYCk4EZmiz4csUv9s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observable change:
polis conversation newpredictions and its setup summary describe current Node behaviour for external IDs. No server change.Node now checks the external-ID allow-list on every join, vote and comment for any request whose external ID is its identity (before resolving it), and treats a changed or unknown external ID, or another owner's token, as a new identity. The model predicted that known identities bypass the list and that a changed ID kept its participant: against live Node, 472 of 2,400 admission cells disagreed.
predict()encodes both rules; all 2,400 match. The setup document is updated, including seed authority.scripts/test-setup-admission.shruns the table (contract predictions vs live Node on generated fixtures) and fails on any mismatch; the CLI comparison workflow runs it after the command comparison, reusing its images.🤖 Generated with Claude Code