Skip to content

observer method #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

observer method #185

wants to merge 2 commits into from

Conversation

PingHsunTsai
Copy link
Collaborator

What type of change is this?

  • Added Observer to handle is_selected state update or more.

@PingHsunTsai PingHsunTsai self-assigned this Jun 26, 2024
@PingHsunTsai PingHsunTsai marked this pull request as draft June 26, 2024 09:43
@jf---
Copy link
Contributor

jf--- commented Jun 25, 2025

@PingHsunTsai & @tomvanmele this looks like a really elegant contribution to me.
Would you reconsider merging?

@jf--- jf--- mentioned this pull request Jul 1, 2025
Open
@tomvanmele
Copy link
Member

i have a bit of cleaning up to do first, but then i will certainly consider it...

@tomvanmele
Copy link
Member

@jf---, @Licini is refactoring the UI system. once that is done, we can try to move this one out of "draft" and merge it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PingHsunTsai PingHsunTsai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PingHsunTsai @jf--- @tomvanmele