Changing straight skeleton return data into Graph
#33
Conversation
|
@tomvanmele Friendly ping! |
docs/examples/straight_skeleton_2.py
Outdated
| viewer.scene.add(graph, edgecolor=(1.0, 0.0, 0.0)) | ||
| viewer.scene.add(polygon) | ||
| for edge in graph.edges(): | ||
| line = Line(*graph.edge_coordinates(edge)) |
There was a problem hiding this comment.
just fyi, there is line = graph.edge_line(edge)
|
|
||
| def graph_from_skeleton_data(skeleton_data) -> Graph: | ||
| Mv, Mvi, Me, Mei = skeleton_data |
There was a problem hiding this comment.
why not split these parameters?
now it is quite difficult for a user to know what the input is supposed to be...
There was a problem hiding this comment.
good point, made the changes and added doc for graph_from_skeleton_data
| @@ -31,10 +48,10 @@ def create_interior_straight_skeleton(points) -> PolylinesNumpy: | |||
| if not TOL.is_allclose(normal, [0, 0, 1]): | |||
| raise ValueError("The normal of the polygon should be [0, 0, 1]. The normal of the provided polygon is {}".format(normal)) | |||
| V = np.asarray(points, dtype=np.float64) | |||
| return straight_skeleton_2.create_interior_straight_skeleton(V) | |||
| return graph_from_skeleton_data(straight_skeleton_2.create_interior_straight_skeleton(V)) | |||
There was a problem hiding this comment.
if you "star" the output, you could split the params in graph_from_skeleton_data
|
|
||
| def graph_from_skeleton_data(points, indices, edges, edge_types) -> Graph: |
There was a problem hiding this comment.
since you annotate the output, perhaps you could also annotate the input?
There was a problem hiding this comment.
i am new to using types for in- and outputs. but I hope this is what you meant now. ;)
| @@ -31,10 +64,10 @@ def create_interior_straight_skeleton(points) -> PolylinesNumpy: | |||
| if not TOL.is_allclose(normal, [0, 0, 1]): | |||
| raise ValueError("The normal of the polygon should be [0, 0, 1]. The normal of the provided polygon is {}".format(normal)) | |||
| V = np.asarray(points, dtype=np.float64) | |||
| return straight_skeleton_2.create_interior_straight_skeleton(V) | |||
| return graph_from_skeleton_data(*straight_skeleton_2.create_interior_straight_skeleton(V)) | |||
There was a problem hiding this comment.
just pointing out that the user can still "only" get a graph as a result and no longer has the option to use the low level output.
perhaps you could add a parameter as_graph and only convert to a graph if that parameter is set to True, which could even be the default...
Updating the return value of straight skeleton 2 from lines to graph. This allows to include more information from the skeleton, e.g. which edges are inner bisectors, bisectors and boundary edges.