Adding straight skeleton with holes #30
Conversation
| lines = create_interior_straight_skeleton_with_holes(polygon, holes) | ||
| graph = Graph.from_lines(lines) |
There was a problem hiding this comment.
if the return value is a list polylines (not lines), it will not always be possible to directly convert this into a graph. perhaps it would be helpful to have a helper for making the conversion...
There was a problem hiding this comment.
The skeleton function is implemented to always return lines, so it should work to always convert them to a graph.
But I agree that the conversion is not proper yet. Ideally the return value should not be PolylinesNumpy, but a compas.datastructures.mesh, as it could represent CGAL's data type for the StraightSkeleton_2:
https://doc.cgal.org/Manual/4.1/doc_html/cgal_manual/Straight_skeleton_2_ref/Concept_StraightSkeleton_2.html#Cross_link_anchor_1072
I anyway plan to add some other functions like the create_interior_weighted_straight_skeleton_2. So maybe I will tackle this in the next PR.
There was a problem hiding this comment.
ok so current one can be merged?
Added skeleton from polygon with holes