Ipy v2 #15

chenkasirer · 2024-09-05T14:50:53Z

Yet another copy of the componentizer script, this one is almost identical with the new CPython one but compiles components as for the new IronPython interpreter of Rhino8.

Necessary changes are visible in 42a8ef4

@9and3 couldn't add you as reviewer, but would be great if you could have a look.

One thing I noticed is Rhino8 seems to be taking the input/output argument names from the metadata and replaces the RunScript args with them. This means that if argument names are different in the script itself (e.g. Centerline vs. centerline) the script will be broken..
It would be nice not to have to change components to match, but I currently don't see any other way..

gonzalocasas

I think we need a change on action.yml to support this new "interpreter" mode, and the corresponding updates on the readme file, other than that, it lgtm

9and3

Lookin good @chenkasirer thanks for tag me! 🌠 just a tiny missing datatype for RV8.
As mentioned by @gonzalocasas the action (and readme) should be updated to have an additional interpreter otpion where in the workflow there would be:

- uses: compas-dev/compas-actions.ghpython_components@v5
        with:
          source: components
          target: build
          interpreter: ipyV8  # or something like this

And the action.yml would have just another case:

compas-actions.ghpython_components/action.yml

Lines 25 to 41 in 42a8ef4

    
               - name: Launch componentizer 
        
                 run: | 
        
                   if ("${{ inputs.interpreter }}" -eq "cpython") { 
        
                     $command="python" 
        
                     $componentizer="${{ github.action_path }}/componentize_cpy.py" 
        
                   } else { 
        
                     $command="ipy" 
        
                     $componentizer="${{ github.action_path }}/componentize_ipy.py" 
        
                   } 
        
                   $params=$componentizer, "${{ inputs.source }}", "${{ inputs.target }}", "--ghio", "./lib" 
        
                   $prefix="${{ inputs.prefix }}" 
        
                   if( $prefix ) 
        
                   { 
        
                     $params=$params + "--prefix", "$prefix" 
        
                   } 
        
                   & $command $params 
        
                 shell: pwsh

9and3 · 2024-09-12T16:01:41Z

componentize_ipy_v2.py

+    brep="2ceb0405-fdfe-403d-a4d6-8786da45fb9d",
+    geometrybase="c37956f4-d39c-49c7-af71-1e87f8031b26",


missing cloud datatype for RV8
pointcloud="d73c9fb0-365d-458f-9fb5-f4141399311f",

9and3 · 2024-09-12T16:02:22Z

componentize_ipy_v2.py

+    # this is new in Rhino8, istead of setting the code as a string, we set it as a base64 blob
+    script = ghpython_root.CreateChunk("Script")
+    code_base64 = base64.b64encode(code.encode("utf-8"))
+    code_base64 = str(code_base64)
+    script.SetString("Text", code_base64)
+    script.SetString("Title", "IPy2")
+    language_spec = script.CreateChunk("LanguageSpec")
+    language_spec.SetString("Taxon", "*.ironpython.python")
+    language_spec.SetString("Version", "2.*")


super nice!

disable the `out` parameter

chenkasirer · 2024-09-13T16:50:49Z

Lookin good @chenkasirer thanks for tag me! 🌠 just a tiny missing datatype for RV8. As mentioned by @gonzalocasas the action (and readme) should be updated to have an additional interpreter otpion where in the workflow there would be:
- uses: compas-dev/compas-actions.ghpython_components@v5
        with:
          source: components
          target: build
          interpreter: ipyV8  # or something like this
And the action.yml would have just another case:

compas-actions.ghpython_components/action.yml

Lines 25 to 41 in 42a8ef4

- name: Launch componentizer

run: |

if ("${{ inputs.interpreter }}" -eq "cpython") {

$command="python"

$componentizer="${{ github.action_path }}/componentize_cpy.py"

} else {

$command="ipy"

$componentizer="${{ github.action_path }}/componentize_ipy.py"

}

$params=$componentizer, "${{ inputs.source }}", "${{ inputs.target }}", "--ghio", "./lib"

$prefix="${{ inputs.prefix }}"

if( $prefix )

{

$params=$params + "--prefix", "$prefix"

}

& $command $params

shell: pwsh

@9and3 thanks so much for taking a look!
I missed a bunch of guids that changes etc, but I think I got it right now.

What do we think about ipy_v2 instead of ipyV8? I tend to like ipy_v2 better..

chenkasirer · 2024-09-13T17:18:23Z

@gonzalocasas @9and3 btw in the course of making this I made a small script which unpacks a compiled component and writes it as XML + code as python. it was really helpful to find out what I was doing wrong.

Not sure where to put it so made a gist: https://gist.github.com/chenkasirer/986edeb23f8e9ce6cf34fb0d4eb7ff9e

gonzalocasas · 2024-09-13T17:22:15Z

@gonzalocasas @9and3 btw in the course of making this I made a small script which unpacks a compiled component and writes it as XML + code as python. it was really helpful to find out what I was doing wrong.

Not sure where to put it so made a gist: https://gist.github.com/chenkasirer/986edeb23f8e9ce6cf34fb0d4eb7ff9e

That's great!!!

gonzalocasas · 2024-09-13T17:25:50Z

Lookin good @chenkasirer thanks for tag me! 🌠 just a tiny missing datatype for RV8. As mentioned by @gonzalocasas the action (and readme) should be updated to have an additional interpreter otpion where in the workflow there would be:
- uses: compas-dev/compas-actions.ghpython_components@v5
        with:
          source: components
          target: build
          interpreter: ipyV8  # or something like this
And the action.yml would have just another case:

compas-actions.ghpython_components/action.yml

Lines 25 to 41 in 42a8ef4

- name: Launch componentizer

run: |

if ("${{ inputs.interpreter }}" -eq "cpython") {

$command="python"

$componentizer="${{ github.action_path }}/componentize_cpy.py"

} else {

$command="ipy"

$componentizer="${{ github.action_path }}/componentize_ipy.py"

}

$params=$componentizer, "${{ inputs.source }}", "${{ inputs.target }}", "--ghio", "./lib"

$prefix="${{ inputs.prefix }}"

if( $prefix )

{

$params=$params + "--prefix", "$prefix"

}

& $command $params

shell: pwsh
@9and3 thanks so much for taking a look!
I missed a bunch of guids that changes etc, but I think I got it right now.

What do we think about ipy_v2 instead of ipyV8? I tend to like ipy_v2 better..

Shouldn't we use the legacy keyword to identify the old stuff like rhino does? ie cpython and ironpython for the new editor and ironpython_legacy for the old one?

9and3 · 2024-09-14T10:33:24Z

Shouldn't we use the legacy keyword to identify the old stuff like rhino does? ie cpython and ironpython for the new editor and ironpython_legacy for the old one?

indeed!

chenkasirer · 2024-09-17T09:39:21Z

Shouldn't we use the legacy keyword to identify the old stuff like rhino does? ie cpython and ironpython for the new editor and ironpython_legacy for the old one?

I like this suggestion.
What I'm worried about it that it would make IronPython2 components the default that are packaged with releases. These aren't backwards compatible. We need to come up with some mechanism that lets us package all versions with release and lets typical users a way to choose which ones to install (as Rhino7 and 8 share the same component directory, you can really have only one or another installed).

chenkasirer · 2024-10-03T09:16:37Z

@gonzalocasas @9and3 so what do we say? I think we should leave the default behavior to be the legacy one to not break Rhino7 compatibility (this action is used directly from main..)
Once we have a good strategy of dealing with the different environments we can do this rework.

gonzalocasas · 2025-01-29T10:23:09Z

Sorry, I forgot about this. There's been additional changes and decisions on this topic. What do we do with this PR? Is it still relevant?

tomvanmele · 2025-01-29T12:21:32Z

i vote, move forward and don't look back :)

chenkasirer · 2025-01-29T12:30:14Z

yeah this seemed like a good idea back then, but now I'm not sure why you'd want to do your GH plugin using ironpython, especially since that r syntax thingy doesn't really work there.

we could merge this as it is, and if someone really want they can make rhino8 ipy comonents, otherwise everything else stays the same. or we could also scrap this, my eyes are on cpython atm.

gonzalocasas · 2025-01-29T12:30:37Z

Don't look back sounds great to me. Time to plan a COMPAS 3.x release entirely dropping IPY support across the board?

chenkasirer · 2025-01-29T12:31:00Z

Don't look back sounds great to me. Time to plan a COMPAS 3.x release entirely dropping IPY support across the board?

amen

gonzalocasas · 2025-01-29T12:51:17Z

we could merge this as it is

👍 go for it!

tomvanmele · 2025-01-29T12:52:54Z

am keeping this for the COMPAS museum. just in case...

chenkasirer added 2 commits September 5, 2024 16:46

duplicate existing ipy script

a919b4e

changes necessary to create modern ipy components

42a8ef4

chenkasirer requested a review from gonzalocasas September 5, 2024 14:51

chenkasirer mentioned this pull request Sep 6, 2024

added build_ghuser_components v2 compas-dev/compas_invocations2#1

Open

10 tasks

gonzalocasas reviewed Sep 10, 2024

View reviewed changes

9and3 reviewed Sep 12, 2024

View reviewed changes

chenkasirer added 7 commits September 13, 2024 17:35

added missing geometry type.

ee08083

disable the `out` parameter

added branch for the new ipy_v2 script

dca0a15

fixed wrong guids

7e8ea33

added example component

344289f

updated readme

dd369a0

updated version of actions/upload-artifact

cb971b3

added new action branch to build workflow

b7f2ff1

chenkasirer merged commit 3d6f04c into main Jan 29, 2025
3 checks passed

chenkasirer deleted the ipy_v2 branch January 29, 2025 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ipy v2 #15

Ipy v2 #15

chenkasirer commented Sep 5, 2024 •

edited

Loading

gonzalocasas left a comment

9and3 left a comment •

edited

Loading

9and3 Sep 12, 2024

9and3 Sep 12, 2024

chenkasirer commented Sep 13, 2024

chenkasirer commented Sep 13, 2024

gonzalocasas commented Sep 13, 2024

gonzalocasas commented Sep 13, 2024

9and3 commented Sep 14, 2024

chenkasirer commented Sep 17, 2024

chenkasirer commented Oct 3, 2024

gonzalocasas commented Jan 29, 2025

tomvanmele commented Jan 29, 2025

chenkasirer commented Jan 29, 2025 •

edited

Loading

gonzalocasas commented Jan 29, 2025

chenkasirer commented Jan 29, 2025

gonzalocasas commented Jan 29, 2025

tomvanmele commented Jan 29, 2025

	- name: Launch componentizer
	run: \|
	if ("${{ inputs.interpreter }}" -eq "cpython") {
	$command="python"
	$componentizer="${{ github.action_path }}/componentize_cpy.py"
	} else {
	$command="ipy"
	$componentizer="${{ github.action_path }}/componentize_ipy.py"
	}
	$params=$componentizer, "${{ inputs.source }}", "${{ inputs.target }}", "--ghio", "./lib"
	$prefix="${{ inputs.prefix }}"
	if( $prefix )
	{
	$params=$params + "--prefix", "$prefix"
	}
	& $command $params
	shell: pwsh

		brep="2ceb0405-fdfe-403d-a4d6-8786da45fb9d",
		geometrybase="c37956f4-d39c-49c7-af71-1e87f8031b26",

Ipy v2 #15

Ipy v2 #15

Conversation

chenkasirer commented Sep 5, 2024 • edited Loading

gonzalocasas left a comment

Choose a reason for hiding this comment

9and3 left a comment • edited Loading

Choose a reason for hiding this comment

9and3 Sep 12, 2024

Choose a reason for hiding this comment

9and3 Sep 12, 2024

Choose a reason for hiding this comment

chenkasirer commented Sep 13, 2024

chenkasirer commented Sep 13, 2024

gonzalocasas commented Sep 13, 2024

gonzalocasas commented Sep 13, 2024

9and3 commented Sep 14, 2024

chenkasirer commented Sep 17, 2024

chenkasirer commented Oct 3, 2024

gonzalocasas commented Jan 29, 2025

tomvanmele commented Jan 29, 2025

chenkasirer commented Jan 29, 2025 • edited Loading

gonzalocasas commented Jan 29, 2025

chenkasirer commented Jan 29, 2025

gonzalocasas commented Jan 29, 2025

tomvanmele commented Jan 29, 2025

chenkasirer commented Sep 5, 2024 •

edited

Loading

9and3 left a comment •

edited

Loading

chenkasirer commented Jan 29, 2025 •

edited

Loading