cli: add feynman extensions to list project and package extensions - #191
Closed
Dünya Baradari (Dunya-8a) wants to merge 1 commit into
Closed
cli: add feynman extensions to list project and package extensions#191Dünya Baradari (Dunya-8a) wants to merge 1 commit into
feynman extensions to list project and package extensions#191Dünya Baradari (Dunya-8a) wants to merge 1 commit into
Conversation
Adds a read-only `feynman extensions` command that lists project-local Pi extensions (loose .ts/.js under ./extensions) and package-provided extensions (installed Pi packages declaring pi.extensions), mirroring `feynman packages list`. Enumeration reuses buildConnectorResources via a new summarizeExtensions() helper so the CLI and workbench stay in sync. Also clarifies the `feynman update` help text: extensions are provided by packages and update with them; there is no separate --extensions flag. Addresses the discovery/help gap behind companion-inc#187.
|
Dünya Baradari (@Dunya-8a) is attempting to deploy a commit to the Companion Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Closing as rejected for product scope. Issue #187 is the narrower update/help defect; #192 already adds the unknown-option help hint and documents that extensions update with their packages. This PR adds a new generic extension-inventory command and workbench resource surface, which is broader than the proven research-loop need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a read-only
feynman extensionscommand that lists:.ts/.jsfiles under./extensionspi.extensionsIt mirrors
feynman packages list. Enumeration reusesbuildConnectorResourcesthrough a newsummarizeExtensions()helper, so the CLI and the workbench stay in sync (single source of truth).Also clarifies the
feynman updatehelp text: extensions are provided by packages and update with them; there is no separate--extensionsflag.Relates to #187.
Why
Addresses the discovery/help gap behind #187.
feynman update --extensionsfailed with a bare "Unknown option" and there was no way to see what extensions are active or understand how they relate to packages. This adds the missing discovery surface and makes the packages↔extensions relationship explicit in help. (#189 separately improves the raw unknown-flag error message.)Example
Empty projects render clean "No project extensions found" / "No installed packages provide extensions" states.
Changes
src/workbench/package-resources.ts— new exportedsummarizeExtensions(workingDir).src/cli.ts—handleExtensionsCommand+ dispatch wiring.metadata/commands.mjs— registeredextensionscommand, added help line, clarifiedupdatedescription.tests/summarize-extensions.test.ts— covers project + package + nested-exclusion + empty cases.Testing
npm run typecheck— cleannpm test— 587/587 pass (2 new)feynman extensionsend-to-end on populated and empty projects.Notes
upstream/main; independent of cli: hint at feynman help on unrecognized flags #189 (the--extensionserror-hint fix). No file overlap, so the two can merge in either order.--extensionsflag (extensions have no independent update lifecycle — they ride along with packages).