CLDC-3860: Bulk upload add validation, prevent reasonpref dontknow being selected #2955
Conversation
|
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2955 |
…tknow-being-selected
…asonpref-dontknow-being-selected' into CLDC-3860-Bulk-upload-prevent-reasonpref-dontknow-being-selected
There was a problem hiding this comment.
This looks good to me! I think we also want the same changes for 2025
There was a problem hiding this comment.
Ye we do, once the 2025 PR is merged we can update it with this or vice versa
| end | ||
| end | ||
|
|
||
| it "does not update the logs with valid rp_dontknow values" do |
There was a problem hiding this comment.
We can check the updated_at field here to verify that the logs haven't been updated
There was a problem hiding this comment.
Good idea, i'll add that in
| dont_know_selected = field_111 == 1 | ||
|
|
||
| if selected_reasons.any? && dont_know_selected | ||
| block_log_creation! |
There was a problem hiding this comment.
Do we really want to block log creation in this case? I assume we should still be able to create logs, but would clear the reasonable preference reasons?
There was a problem hiding this comment.
Ok sure let's do that, will update it
No description provided.