Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDC-3803 Add lettings 25/26 BU #2939

Merged
merged 12 commits into from
Feb 27, 2025
Merged

Conversation

kosiakkatrina
Copy link
Collaborator

@kosiakkatrina kosiakkatrina commented Feb 12, 2025

These are the row numbers that changed from 2024 in row parser:

16 -> 18
17 -> 19
18 -> 20
19 -> 21
20 -> 22
21 -> 23
22 -> 24
23 -> 25
25 -> 17
24 -> 16
36 -> 37
37 -> 38
38 -> 39
39 -> 40
40 -> 41
41 -> 36
124 - removed
125 -> 124
126 -> 125
127 -> 126
128 -> 127
129 -> 128
130 -> 129

Other than that, there's some person relationship mapping that got added cause we changed the input type in the template from string to integer and reduced options.

The easiest way to see the changes in the row parser from 2024 is in these 2 commits: Update row parser field numbers
Add "specified accommodation" to rent type mapping

And all the changes to csv parser should be contained here: Update csv parser

The rest of the changes are just connecting things together

Copy link

Copy link
Contributor

@carolynbarker carolynbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! A few small comments. I checked the field numbers until my eyes glazed over, it's one of those things that's hard to check 100% though so testing is the way to go

end
end

context "when a supported housing log with chcharges already exists in the db" do
context "when a supported housing log with already exists in the db (2)" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chcharces doesn't exist now, right? What's the difference now between this test and the one now on line 496?

Copy link
Collaborator Author

@kosiakkatrina kosiakkatrina Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think they might be the same! Removed it now

end

def create_2025_test_sales_bulk_upload; end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'll fill this out

@kosiakkatrina kosiakkatrina added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 71c3f41 Feb 27, 2025
15 checks passed
@kosiakkatrina kosiakkatrina deleted the CLDC-3803-add-lettings-25-26-bu branch February 27, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants