-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDC-3803 Add lettings 25/26 BU #2939
Conversation
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2939 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! A few small comments. I checked the field numbers until my eyes glazed over, it's one of those things that's hard to check 100% though so testing is the way to go
end | ||
end | ||
|
||
context "when a supported housing log with chcharges already exists in the db" do | ||
context "when a supported housing log with already exists in the db (2)" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chcharces doesn't exist now, right? What's the difference now between this test and the one now on line 496?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think they might be the same! Removed it now
end | ||
|
||
def create_2025_test_sales_bulk_upload; end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'll fill this out
9495c66
to
cd6120e
Compare
4e841f5
to
2d086dc
Compare
These are the row numbers that changed from 2024 in row parser:
Other than that, there's some person relationship mapping that got added cause we changed the input type in the template from string to integer and reduced options.
The easiest way to see the changes in the row parser from 2024 is in these 2 commits: Update row parser field numbers
Add "specified accommodation" to rent type mapping
And all the changes to csv parser should be contained here: Update csv parser
The rest of the changes are just connecting things together