Update rails to 7.2.2 #2856
Update rails to 7.2.2 #2856
Conversation
kosiakkatrina
force-pushed
the
update-rails-7.2.2
branch
from
6c75ec7 to
01b25df
Compare
|
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2856 |
kosiakkatrina
had a problem deploying
to
review
GitHub Actions
Failure
kosiakkatrina
force-pushed
the
update-rails-7.2.2
branch
from
8239e3a to
8fee431
Compare
kosiakkatrina
had a problem deploying
to
review
GitHub Actions
Failure
kosiakkatrina
had a problem deploying
to
review
GitHub Actions
Failure
kosiakkatrina
force-pushed
the
update-rails-7.2.2
branch
from
7ff4eb4 to
2a9db93
Compare
| govuk_link_to "Clear", clear_filters_path(filter_type:, path_params:) | ||
| govuk_link_to "Clear", clear_filters_path(filter_type:, filter_path_params:) |
There was a problem hiding this comment.
Path_params kept on getting cleared, I think because of this: rails/rails#43770
| enum :log_type, { lettings: "lettings", sales: "sales" } | ||
| enum :rent_type_fix_status, { not_applied: "not_applied", applied: "applied", not_needed: "not_needed" } | ||
| enum :failure_reason, { blank_template: "blank_template", wrong_template: "wrong_template" } |
There was a problem hiding this comment.
Our current syntax is deprecated in Rails 8
| @@ -7,7 +7,6 @@ def initialize(id, hsh, page) | |||
| @check_answers_card_number = 0 | |||
| @max = 150 | |||
| @min = 0 | |||
| @hint_text = I18n.t("hints.offered") | |||
There was a problem hiding this comment.
This question is a 2023 question, but the translation for this is missing. We now get an exception because of config.i18n.raise_on_missing_translations
| @@ -13,7 +13,9 @@ class MergeRequest < ApplicationRecord | |||
| request_merged: "request_merged", | |||
| deleted: "deleted", | |||
| }.freeze | |||
| enum status: STATUS | |||
|
|
|||
| attribute :status, :string | |||
There was a problem hiding this comment.
Enums now have to be backed by either a db column or an attribute
| @@ -0,0 +1,17 @@ | |||
| en: | |||
There was a problem hiding this comment.
Don't know if this is the best place to put it, but as we raise all our missing translations, we have some that are only used in tests
There was a problem hiding this comment.
This feels like a sign we should maybe get rid of them...although actually these are coming from test form definitions, right? Probably not too bad, and can't really think of anywhere better for them to go.
| if LocalAuthority.count.zero? | ||
| la_path = "config/local_authorities_data/initial_local_authorities.csv" | ||
| service = Imports::LocalAuthoritiesService.new(path: la_path) | ||
| service.call | ||
| end |
There was a problem hiding this comment.
enums can't be empty {} so this fixes location/scheme tests
| @@ -0,0 +1,17 @@ | |||
| en: | |||
There was a problem hiding this comment.
This feels like a sign we should maybe get rid of them...although actually these are coming from test form definitions, right? Probably not too bad, and can't really think of anywhere better for them to go.
kosiakkatrina
force-pushed
the
update-rails-7.2.2
branch
from
1c51427 to
8173a40
Compare
kosiakkatrina
force-pushed
the
update-rails-7.2.2
branch
from
df6a44c to
98a274f
Compare
No description provided.