Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/PRSD-NONE: mock one login endpoint #9

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

Kiran-R-K
Copy link
Contributor

Description

This PR creates a mock of the One Login Oauth2 API that will automatically run when the project is started in the local profile. It will log the user in as a user who has all possible roles.

Testing

This has been manually tested to see that it works but there are no automated tests.

Possible concerns

I have not mocked the logout endpoint because it requires our web app to have a logout journey/route which we don't yet. If we implement one we will need to also add a logout endpoint to the mock.

Error handling - I have not added error handling to these endpoints - I'm not sure it's necessary for our purpose

Documentation

I've added information to the README about this mock, including: how to use it, how to change the user you're logged in as and a reminder to add any new roles to the userId we are using to login.

Copy link
Contributor

@isobel-softwire isobel-softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM - left a few comments

Copy link
Collaborator

@Travis-Softwire Travis-Softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left a few Qs and suggestions, but otherwise this is looking good :)

@Kiran-R-K Kiran-R-K merged commit ea86d1f into main Oct 23, 2024
1 check passed
@Kiran-R-K Kiran-R-K deleted the chore/PRSD-NONE-mock-one-login-endpoint branch October 23, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants