-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/PRSD-NONE: mock one login endpoint #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM - left a few comments
...main/kotlin/uk/gov/communities/prsdb/webapp/local/api/mockOneLogin/MockOneLoginController.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/uk/gov/communities/prsdb/webapp/local/api/mockOneLogin/MockOneLoginController.kt
Outdated
Show resolved
Hide resolved
...main/kotlin/uk/gov/communities/prsdb/webapp/local/api/mockOneLogin/MockOneLoginController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/local/api/mockOneLogin/MockOneLoginHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/local/api/controller/MockOneLoginController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/local/api/helper/MockOneLoginHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/local/api/helper/MockOneLoginHelper.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have left a few Qs and suggestions, but otherwise this is looking good :)
rowanhill
reviewed
Oct 18, 2024
src/main/kotlin/uk/gov/communities/prsdb/webapp/local/api/controller/MockOneLoginController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/local/api/controller/MockOneLoginController.kt
Outdated
Show resolved
Hide resolved
rowanhill
reviewed
Oct 22, 2024
src/main/kotlin/uk/gov/communities/prsdb/webapp/local/api/controller/MockOneLoginController.kt
Outdated
Show resolved
Hide resolved
rowanhill
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a mock of the One Login Oauth2 API that will automatically run when the project is started in the
local
profile. It will log the user in as a user who has all possible roles.Testing
This has been manually tested to see that it works but there are no automated tests.
Possible concerns
I have not mocked the
logout
endpoint because it requires our web app to have a logout journey/route which we don't yet. If we implement one we will need to also add alogout
endpoint to the mock.Error handling - I have not added error handling to these endpoints - I'm not sure it's necessary for our purpose
Documentation
I've added information to the
README
about this mock, including: how to use it, how to change the user you're logged in as and a reminder to add any new roles to theuserId
we are using to login.