Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/prsd 670 landlord dashboard absolute url #244

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

JasminConterioSW
Copy link
Contributor

@JasminConterioSW JasminConterioSW commented Feb 27, 2025

This does not complete PRSD-670, but the aim is to get a working absolute landlord url for use in emails, in a way that can be mocked if necessary in tests.

  • Create a skeleton landlord dashboard controller / template / endpoint
  • Add AbsoluteUrlProvider to generate the absolute urls that are sent in emails
  • Move the existing buildInvitationUri() function to the new provider
  • Add a new buildLandlordDashboardUri() function to the new provider

This does not yet add tests of the url but I have manually checked that the links in property registration confirmation, landlord registration confirmation and la user invitation emails all work (I'm working on it but these can be in a later PR)

Copy link
Collaborator

@rowanhill rowanhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems fairly uncontroversial, so far!

@JasminConterioSW JasminConterioSW added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit d3323eb Feb 27, 2025
1 check passed
@JasminConterioSW JasminConterioSW deleted the feat/PRSD-670-landlord-dashboard-absolute-url branch February 27, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants