-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRSD-353: Registration Number Service #10
PRSD-353: Registration Number Service #10
Conversation
src/main/kotlin/uk/gov/communities/prsdb/webapp/database/repository/LandlordRepository.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberServiceTests.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberServiceTests.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberServiceTests.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/uk/gov/communities/prsdb/webapp/services/ServiceTest.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/database/entity/RegistrationNumber.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good I think. I've left a few comments, but would appreciate @rowanhill's view as he designed the registration numbers :)
src/main/kotlin/uk/gov/communities/prsdb/webapp/constants/RegistrationNumberConstants.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/constants/enums/RegistrationNumberType.kt
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/database/entity/RegistrationNumber.kt
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Outdated
Show resolved
Hide resolved
src/main/resources/db/migrations/V1_0_1__reg_num_and_landlord_skeleton.sql
Outdated
Show resolved
Hide resolved
…a RegistrationNumberDataModel instead of a RegisteredEntity
src/main/kotlin/uk/gov/communities/prsdb/webapp/services/RegistrationNumberService.kt
Outdated
Show resolved
Hide resolved
…rvice to RegistrationNumberDataModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the tweaks - this looks good to me now!
Overarching Changes
ModifiableAuditableEntity
and makesAuditableEntity
its descendant.ServiceTest
RegisteredEntity
interface for entities with registration numbers (this allows for genericRegistrationNumberService
methods)Features
RegistrationNumber
and aLandlord
skeleton to the database.RegistrationNumberService
that can:Tests
RegistrationNumberService
methodsNotes
RegistrationNumberService.retrieveEntity
as entities with registration numbers (apart from landlord) are yet to be implemented.