Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRSD-353: Registration Number Service #10

Merged
merged 27 commits into from
Oct 17, 2024

Conversation

isobel-softwire
Copy link
Contributor

@isobel-softwire isobel-softwire commented Oct 15, 2024

Overarching Changes

  • Creates base ModifiableAuditableEntity and makes AuditableEntity its descendant.
  • Creates base ServiceTest
  • Creates RegisteredEntity interface for entities with registration numbers (this allows for generic RegistrationNumberService methods)

Features

  • Adds RegistrationNumber and a Landlord skeleton to the database.
  • Creates RegistrationNumberService that can:
    • Create registration numbers
    • Convert between integer and formatted registration numbers
    • Retrieve an entity based on its registration number
  • Displays a formatted registration number on the webapp's landing page for PoC.

Tests

  • Tests for RegistrationNumberService methods

Notes

  • Decided against displaying a registration number based on seed data as the features required for this are outside this ticket's scope.
  • TODOs left in RegistrationNumberService.retrieveEntity as entities with registration numbers (apart from landlord) are yet to be implemented.

Copy link
Collaborator

@Travis-Softwire Travis-Softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good I think. I've left a few comments, but would appreciate @rowanhill's view as he designed the registration numbers :)

Copy link
Collaborator

@rowanhill rowanhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the tweaks - this looks good to me now!

@isobel-softwire isobel-softwire merged commit ffd2388 into main Oct 17, 2024
1 check passed
@isobel-softwire isobel-softwire deleted the feat/PRSD-353-registration-number-service branch October 17, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants