Merge pull request #186 from communitiesuk/scrolly-table

Scrolly table - fixed headers
communitiesuk · Dec 20, 2024 · d063283 · d063283
2 parents d1367e7 + 95cd53c
commit d063283
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 22 deletions.
diff --git a/gov_uk_dashboards/components/plotly/table.py b/gov_uk_dashboards/components/plotly/table.py
@@ -4,7 +4,8 @@
 from dash import html, dcc
 from gov_uk_dashboards.components.plotly.card import card
 from gov_uk_dashboards.components.plotly.paragraph import paragraph
-from gov_uk_dashboards.components.plotly.row_component import row_component
+
+# from gov_uk_dashboards.components.plotly.row_component import row_component
 
 
 def table_from_dataframe(
@@ -260,24 +261,39 @@ def table_from_polars_dataframe(
         )
     )
 
-    return row_component(
-        card(
-            row_component(
-                card(
-                    [
-                        html.Table(
-                            table_contents,
-                            className="govuk-table table-header-cell-top-padding",
-                            id=table_id,
-                            role="table",
-                            **table_properties,
-                        ),
-                        paragraph(table_footer) if table_footer else None,
-                    ],
-                    amend_style={"padding": "0px"},
-                ),
-                horizontal_scroll=True,
-            )
-        ),
-        horizontal_scroll=True,
+    # commented below out as prevents sticky header, although now not optimised for mobile devices
+    return card(
+        [
+            html.Table(
+                table_contents,
+                className="govuk-table table-header-cell-top-padding",
+                id=table_id,
+                role="table",
+                **table_properties,
+            ),
+            paragraph(table_footer) if table_footer else None,
+        ],
+        amend_style={"padding": "0px"},
     )
+
+    # return row_component(
+    #     card(
+    #         row_component(
+    #             card(
+    #                 [
+    #                     html.Table(
+    #                         table_contents,
+    #                         className="govuk-table table-header-cell-top-padding",
+    #                         id=table_id,
+    #                         role="table",
+    #                         **table_properties,
+    #                     ),
+    #                     paragraph(table_footer) if table_footer else None,
+    #                 ],
+    #                 amend_style={"padding": "0px"},
+    #             ),
+    #             horizontal_scroll=True,
+    #         )
+    #     ),
+    #     horizontal_scroll=True,
+    # )
diff --git a/setup.py b/setup.py
@@ -10,7 +10,7 @@
     author="Department for Levelling Up, Housing and Communities",
     description="Provides access to functionality common to creating a data dashboard.",
     name="gov_uk_dashboards",
-    version="12.3.4",
+    version="13.0.0",
     long_description=long_description,
     long_description_content_type="text/markdown",
     packages=find_packages(),