Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

BAU: add basic auth on dev #96

Merged
merged 1 commit into from
Mar 21, 2024
Merged

BAU: add basic auth on dev #96

merged 1 commit into from
Mar 21, 2024

Conversation

gidsg
Copy link
Contributor

@gidsg gidsg commented Mar 21, 2024

Change description

Sister PR to: communitiesuk/funding-service-design-post-award-submit#144

Previously we had basic auth on test but not dev, this adds basic auth on dev.

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

Basic auth should be enabled on the dev environment

Screenshots of UI changes (if applicable)

Copy link
Contributor

@MarcUsher MarcUsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gidsg gidsg merged commit 2bd5aa5 into main Mar 21, 2024
5 checks passed
@gidsg gidsg deleted the bau-basic-auth-dev branch March 21, 2024 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants