Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

frontend changes for async_download #123

Merged
merged 1 commit into from
Jul 11, 2024
Merged

frontend changes for async_download #123

merged 1 commit into from
Jul 11, 2024

Conversation

sc15zs
Copy link
Contributor

@sc15zs sc15zs commented Jul 4, 2024

Ticket:
https://dluhcdigital.atlassian.net/browse/FPASF-103

Description:
Frontend changes for changing direct file download to a background task.

Comments:

  • Does not include the two new routes for retrieving files
  • Unit tests for testing direct download functionality have been commented out for now.

@samuelhwilliams samuelhwilliams marked this pull request as draft July 5, 2024 08:51
@samuelhwilliams
Copy link
Contributor

I've just flipped this to a draft PR as a bit of extra protection against us merging it prematurely - we need to get everything else lined up before we can click the green button. But this is still fine to review.

@samuelhwilliams
Copy link
Contributor

This looks good to go as soon as we have sign-off from QA/product that we're happy to release it :)

@samuelhwilliams samuelhwilliams marked this pull request as ready for review July 11, 2024 09:38
@sc15zs sc15zs merged commit 9282b7b into main Jul 11, 2024
5 checks passed
@sc15zs sc15zs deleted the async_download branch July 11, 2024 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants