Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

FPASF-143: fix download report #119

Merged
merged 5 commits into from
Jun 14, 2024
Merged

FPASF-143: fix download report #119

merged 5 commits into from
Jun 14, 2024

Conversation

gidsg
Copy link
Contributor

@gidsg gidsg commented Jun 14, 2024

Change description

The download reporting mechanism was broken by the refactoring in: 025cf8f

This PR

  • Restores the request_type key that was removed
  • Makes the logs query backwards compatible so we can retrieve the logs using the refactored format
  • Adds a unit test to make this interface harder to break in future
  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

Script should return results for recent period e.g. python3 ./scripts/extract_download_logs.py -e dev -m 1 (with dev AWS credentials.)

Screenshots of UI changes (if applicable)

@gidsg gidsg merged commit df286df into main Jun 14, 2024
2 checks passed
@gidsg gidsg deleted the FPASF-143-fix-download-report branch June 14, 2024 16:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants