change 'get' to 'post' to call data-store

communitiesuk · Jul 1, 2024 · 6e82e83 · 6e82e83
1 parent cb914b8
commit 6e82e83
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/app/main/download_data.py b/app/main/download_data.py
@@ -243,9 +243,13 @@ def process_api_response(query_params: dict) -> tuple:
 
 
 def process_async_download(query_params: dict):
+    """Calls data-store for a file download request.
+
+    :param query_params: Query parameters for the API request.
+    """
     request_url = (
         Config.DATA_STORE_API_HOST
         + "/trigger_async_download"
         + ("?" + urlencode(query_params, doseq=True) if query_params else "")
     )
-    requests.get(request_url)
+    requests.post(request_url)
diff --git a/tests/test_logging.py b/tests/test_logging.py
@@ -2,11 +2,11 @@
 
 
 @pytest.fixture
-def mocked_async_download(mocker):
-    return mocker.patch("app.main.download_data.process_async_download", return_value=True)
+def mock_get_response_basic_download(flask_test_client, mocker):
+    mocker.patch("app.main.routes.process_async_download", return_value=True)
 
 
-def test_download_logging(flask_test_client, caplog, mocked_async_download):
+def test_download_logging(flask_test_client, caplog, mock_get_response_basic_download):
     flask_test_client.post("/download", data={"file_format": "xlsx"})
     log_line = [record for record in caplog.records if hasattr(record, "request_type")]
     assert len(log_line) == 1