FS-5044 - Add role-based auth to FAB #303
Open
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrm500
force-pushed
the
FS-5044_add-role-based-auth-to-fab
branch
from
0b1fb37 to
50a7408
Compare
|
| @@ -28,7 +28,9 @@ def protect_private_routes(flask_app: Flask) -> Flask: | |||
| if endpoint in PUBLIC_ROUTES: | |||
| continue | |||
| flask_app.view_functions[endpoint] = login_required( | |||
| check_internal_user(view_func), return_app=SupportedApp.FUND_APPLICATION_BUILDER | |||
| check_internal_user(view_func), | |||
| roles_required=["FSD_ADMIN"], | |||
There was a problem hiding this comment.
Cant we send this as a param of roles list ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Add role-based auth to FAB
Description
Users must be a member of the 'FSD_ADMIN' group in Azure AD to authenticate for FAB, as per TDA requirements.